linux-kernel - Re: [PATCH bpf-next 1/1] selftests/bpf: Enable Tx hwtstamp in xdp_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1B50w1jzHFt-LuA@mini-arch>
Date: Wed, 4 Dec 2024 07:48:35 -0800
From: Stanislav Fomichev <stfomichev@...il.com>
To: Song Yoong Siang <yoong.siang.song@...el.com>
Cc: Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	"David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>,
	Jesper Dangaard Brouer <hawk@...nel.org>,
	John Fastabend <john.fastabend@...il.com>,
	Andrii Nakryiko <andrii@...nel.org>,
	Eduard Zingerman <eddyz87@...il.com>,
	Mykola Lysenko <mykolal@...com>,
	Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>,
	Yonghong Song <yonghong.song@...ux.dev>,
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
	Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
	Shuah Khan <shuah@...nel.org>, netdev@...r.kernel.org,
	bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next 1/1] selftests/bpf: Enable Tx hwtstamp in
 xdp_hw_metadata

On 12/04, Song Yoong Siang wrote:
> Set tx_type to HWTSTAMP_TX_ON to enable hardware timestamping for all
> outgoing packets.
> 
> Besides, set XDP_UMEM_TX_METADATA_LEN flag to reserve tx_metadata_len bytes
> of per-chunk metadata.

XDP_UMEM_TX_METADATA_LEN is missing after d5e726d9143c ("xsk: Require
XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"), so that make
sense. Maybe add a fixes tag?

And I don't see mlx5 looking at HWTSTAMP_TX anywhere in the drivers,
so I'm assuming that's why I didn't need HWTSTAMP_TX_ON during my tests..
Which device are you testing against? I do see some hwts_tx_en
checks in the stfmmac at least... Can you add these details to the
commit message and respin?

With the above addressed:
Acked-by: Stanislav Fomichev <sdf@...ichev.me>