linux-kernel - Re: [PATCH v2] staging: rtl8723bs: fix broken code when cflag is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024120426-shininess-scorpion-cc26@gregkh>
Date: Wed, 4 Dec 2024 16:52:55 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
Cc: philipp.g.hortmann@...il.com, ~lkcamp/patches@...ts.sr.ht,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: fix broken code when cflag is used

On Mon, Nov 25, 2024 at 07:45:04PM -0300, Rodrigo Gobbi wrote:
> When using an extra cflag, DBG_RX_SIGNAL_DISPLAY_RAW_DATA,
> hal_com.c file doesn't compile.
> 
> Fixes: ec57f8641fbc ("staging: rtl8723bs: Rework 'struct _ODM_Phy_Status_Info_' coding style.")
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
> ---
> As noticed at [1], hal_com.c is not compiling with -DDBG_RX_SIGNAL_DISPLAY_RAW_DATA due
> the changes at [2] (a few statements were not replaced with the new struct).
> A little discussion was made at [1] too about how useful this cflag was or if
> the code under the cflag should be deleted. I think there is no harm to keep those things 
> as is since we can easily fix the error and someone might be interested in using that
> to further debug the driver.

Let's just delete that flag entirely, no one builds in-kernel modules
with different cflags.  Please just remove the code completly.

thanks,

greg k-h