linux-kernel - Re: [PATCH v4] staging: gpib: Fix i386 build issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024120444-apron-levers-d701@gregkh>
Date: Wed, 4 Dec 2024 16:56:57 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Dave Penkler <dpenkler@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH v4] staging: gpib: Fix i386 build issue

On Wed, Dec 04, 2024 at 04:36:12PM +0100, Dave Penkler wrote:
> These drivers cast resource_type_t to void * causing the build to fail.
> 
> With CONFIG_X86_PAE enabled the resource_size_t type is a 64bit unsigned int
> which cannot be cast to a 32 bit pointer.
> 
> Disable these drivers if X68_PAE is enabled
> 
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Link: https://lore.kernel.org/all/f10e976e-7a04-4454-b38d-39cd18f142da@roeck-us.net/
> Fixes: e9dc69956d4d ("staging: gpib: Add Computer Boards GPIB driver")
> Fixes: e1339245eba3 ("staging: gpib: Add Computer Equipment Corporation GPIB driver")
> Fixes: bb1bd92fa0f2 ("staging: gpib: Add ines GPIB driver")
> Fixes: 0cd5b05551e0 ("staging: gpib: Add TNT4882 chip based GPIB driver")
> ---
> v1 -> v2 changed pci_resource_start to pci_resource_len for second parameter of ioremap
> v2 -> v3 add changes for cb7210 and tnt4882 drivers
> v3 -> v4 disable build of drivers when X86_PAE is enabled

You forgot to sign off on this change :(

v5?

thanks,

greg k-h