linux-kernel - Re: [PATCH v5 2/2] cpufreq: airoha: Add EN7581 CPUFreq SMCCC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <675071ab.7b0a0220.183cea.8610@mx.google.com>
Date: Wed, 4 Dec 2024 16:13:43 +0100
From: Christian Marangi <ansuelsmth@...il.com>
To: kernel test robot <lkp@...el.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-pm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	upstream@...oha.com, llvm@...ts.linux.dev,
	oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH v5 2/2] cpufreq: airoha: Add EN7581 CPUFreq SMCCC driver

On Wed, Dec 04, 2024 at 07:22:41PM +0800, kernel test robot wrote:
> Hi Christian,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on rafael-pm/linux-next]
> [also build test ERROR on rafael-pm/bleeding-edge robh/for-next linus/master v6.13-rc1 next-20241203]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/cpufreq-airoha-Add-EN7581-CPUFreq-SMCCC-driver/20241204-113105
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
> patch link:    https://lore.kernel.org/r/20241203163158.580-2-ansuelsmth%40gmail.com
> patch subject: [PATCH v5 2/2] cpufreq: airoha: Add EN7581 CPUFreq SMCCC driver
> config: arm-randconfig-003 (https://download.01.org/0day-ci/archive/20241204/202412041929.8aCqrGnO-lkp@intel.com/config)
> compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241204/202412041929.8aCqrGnO-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202412041929.8aCqrGnO-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/cpufreq/airoha-cpufreq.c:41:34: error: variable has incomplete type 'const struct arm_smccc_1_2_regs'
>       41 |         const struct arm_smccc_1_2_regs args = {
>          |                                         ^
>    drivers/cpufreq/airoha-cpufreq.c:41:15: note: forward declaration of 'struct arm_smccc_1_2_regs'
>       41 |         const struct arm_smccc_1_2_regs args = {
>          |                      ^
> >> drivers/cpufreq/airoha-cpufreq.c:45:28: error: variable has incomplete type 'struct arm_smccc_1_2_regs'
>       45 |         struct arm_smccc_1_2_regs res;
>          |                                   ^
>    drivers/cpufreq/airoha-cpufreq.c:41:15: note: forward declaration of 'struct arm_smccc_1_2_regs'
>       41 |         const struct arm_smccc_1_2_regs args = {
>          |                      ^
> >> drivers/cpufreq/airoha-cpufreq.c:47:2: error: call to undeclared function 'arm_smccc_1_2_smc'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>       47 |         arm_smccc_1_2_smc(&args, &res);
>          |         ^
>    drivers/cpufreq/airoha-cpufreq.c:81:34: error: variable has incomplete type 'const struct arm_smccc_1_2_regs'
>       81 |         const struct arm_smccc_1_2_regs args = {
>          |                                         ^
>    drivers/cpufreq/airoha-cpufreq.c:81:15: note: forward declaration of 'struct arm_smccc_1_2_regs'
>       81 |         const struct arm_smccc_1_2_regs args = {
>          |                      ^
>    drivers/cpufreq/airoha-cpufreq.c:86:28: error: variable has incomplete type 'struct arm_smccc_1_2_regs'
>       86 |         struct arm_smccc_1_2_regs res;
>          |                                   ^
>    drivers/cpufreq/airoha-cpufreq.c:81:15: note: forward declaration of 'struct arm_smccc_1_2_regs'
>       81 |         const struct arm_smccc_1_2_regs args = {
>          |                      ^
>    drivers/cpufreq/airoha-cpufreq.c:88:2: error: call to undeclared function 'arm_smccc_1_2_smc'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>       88 |         arm_smccc_1_2_smc(&args, &res);
>          |         ^
>    6 errors generated.
> 
> 
> vim +41 drivers/cpufreq/airoha-cpufreq.c
> 
>     37	
>     38	static unsigned long airoha_cpufreq_clk_get(struct clk_hw *hw,
>     39						    unsigned long parent_rate)
>     40	{
>   > 41		const struct arm_smccc_1_2_regs args = {
>     42			.a0 = AIROHA_SIP_AVS_HANDLE,
>     43			.a1 = AIROHA_AVS_OP_GET_FREQ,
>     44		};
>   > 45		struct arm_smccc_1_2_regs res;
>     46	
>   > 47		arm_smccc_1_2_smc(&args, &res);
>     48	
>     49		/* SMCCC returns freq in MHz */
>     50		return (int)(res.a0 * 1000 * 1000);
>     51	}
>     52	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

False positive or better say my error in the kconfig depends logic

This driver REQUIRE ARM64 bit for smccc and the target SoC is 64bit
only. The randconfig catch a situation with ARCH_AIROHA and 32bit.

-- 
	Ansuel