linux-kernel - Re: [PATCH] of: Hide of_default_bus_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGETcx8uJF30UvK_4PUu2R+juYa33CXEZrnSLG9nWXN2TPL4wg@mail.gmail.com>
Date: Tue, 3 Dec 2024 19:07:51 -0800
From: Saravana Kannan <saravanak@...gle.com>
To: Stephen Boyd <swboyd@...omium.org>
Cc: Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org, patches@...ts.linux.dev, 
	devicetree@...r.kernel.org
Subject: Re: [PATCH] of: Hide of_default_bus_match_table[]

On Tue, Dec 3, 2024 at 4:04 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> This isn't used outside this file. Hide the array in the C file.
>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>

Acked-by: Saravana Kannan <saravanak@...gle.com>

> ---
>  drivers/of/platform.c       | 2 +-
>  include/linux/of_platform.h | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index 9bafcff3e628..f09dc183975b 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -24,7 +24,7 @@
>
>  #include "of_private.h"
>
> -const struct of_device_id of_default_bus_match_table[] = {
> +static const struct of_device_id of_default_bus_match_table[] = {
>         { .compatible = "simple-bus", },
>         { .compatible = "simple-mfd", },
>         { .compatible = "isa", },
> diff --git a/include/linux/of_platform.h b/include/linux/of_platform.h
> index a2ff1ad48f7f..17471ef8e092 100644
> --- a/include/linux/of_platform.h
> +++ b/include/linux/of_platform.h
> @@ -47,8 +47,6 @@ struct of_dev_auxdata {
>         { .compatible = _compat, .phys_addr = _phys, .name = _name, \
>           .platform_data = _pdata }
>
> -extern const struct of_device_id of_default_bus_match_table[];
> -
>  /* Platform drivers register/unregister */
>  extern struct platform_device *of_device_alloc(struct device_node *np,
>                                          const char *bus_id,
>
> base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
> --
> https://chromeos.dev
>