linux-kernel - Re: [PATCH 5/6] nvmem: rmem: add CRC validation for Mobileye EyeQ5 NVMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D632UZERSM8I.1O3J7O9QZ64EV@bootlin.com>
Date: Wed, 04 Dec 2024 18:04:10 +0100
From: Théo Lebrun <theo.lebrun@...tlin.com>
To: "kernel test robot" <lkp@...el.com>
Cc: <oe-kbuild-all@...ts.linux.dev>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-mips@...r.kernel.org>, "Vladimir
 Kondratiev" <vladimir.kondratiev@...ileye.com>,
 Grégory Clement <gregory.clement@...tlin.com>, "Thomas
 Petazzoni" <thomas.petazzoni@...tlin.com>, "Tawfik Bayouk"
 <tawfik.bayouk@...ileye.com>, Théo Lebrun
 <theo.lebrun@...tlin.com>, "Srinivas Kandagatla"
 <srinivas.kandagatla@...aro.org>, "Rob Herring" <robh@...nel.org>,
 "Krzysztof Kozlowski" <krzk@...nel.org>, "Conor Dooley"
 <conor+dt@...nel.org>, "Nicolas Saenz Julienne" <nsaenz@...nel.org>,
 "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>
Subject: Re: [PATCH 5/6] nvmem: rmem: add CRC validation for Mobileye EyeQ5
 NVMEM

On Wed Dec 4, 2024 at 8:58 AM CET, kernel test robot wrote:
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on 40384c840ea1944d7c5a392e8975ed088ecf0b37]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Th-o-Lebrun/dt-bindings-nvmem-rmem-Add-mobileye-eyeq5-bootloader-config/20241204-103417
> base:   40384c840ea1944d7c5a392e8975ed088ecf0b37
> patch link:    https://lore.kernel.org/r/20241203-rmem-v1-5-24f4970cf14e%40bootlin.com
> patch subject: [PATCH 5/6] nvmem: rmem: add CRC validation for Mobileye EyeQ5 NVMEM
> config: arm-randconfig-002 (https://download.01.org/0day-ci/archive/20241204/202412041522.01H5Kj6F-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241204/202412041522.01H5Kj6F-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202412041522.01H5Kj6F-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    drivers/nvmem/rmem.c: In function 'rmem_eyeq5_checksum':
>    drivers/nvmem/rmem.c:66:9: error: cleanup argument not a function
>       66 |         void *buf __free(kfree) = NULL;
>          |         ^~~~
>    drivers/nvmem/rmem.c:97:15: error: implicit declaration of function 'kmalloc'; did you mean 'mm_alloc'? [-Wimplicit-function-declaration]
>       97 |         buf = kmalloc(header.size, GFP_KERNEL);
>          |               ^~~~~~~
>          |               mm_alloc
> >> drivers/nvmem/rmem.c:97:13: error: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>       97 |         buf = kmalloc(header.size, GFP_KERNEL);
>          |             ^

Will fix with the following.
V2 incoming in a few days to avoid spam.

	diff --git a/drivers/nvmem/rmem.c b/drivers/nvmem/rmem.c
	index 04796f4fa8ae..1f0caf1d2dc1 100644
	--- a/drivers/nvmem/rmem.c
	+++ b/drivers/nvmem/rmem.c
	@@ -9,6 +9,7 @@
	 #include <linux/nvmem-provider.h>
	 #include <linux/of_reserved_mem.h>
	 #include <linux/platform_device.h>
	+#include <linux/slab.h>

	 struct rmem {
	        struct device *dev;

Regards,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com