linux-kernel - Re: [PATCH 0/5] cpufreq/amd-pstate: Reuse and refactor code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9cd10b8b-ff56-4171-ad9c-df84fdad6be2@amd.com>
Date: Wed, 4 Dec 2024 11:07:58 -0600
From: Mario Limonciello <mario.limonciello@....com>
To: Dhananjay Ugwekar <Dhananjay.Ugwekar@....com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 gautham.shenoy@....com, perry.yuan@....com, rafael@...nel.org,
 viresh.kumar@...aro.org
Subject: Re: [PATCH 0/5] cpufreq/amd-pstate: Reuse and refactor code

On 12/4/2024 08:48, Dhananjay Ugwekar wrote:
> Use static calls to avoid frequent MSR/shared memory system checks.
> 
> Reuse existing functions amd_pstate_update_perf() and
> amd_pstate_set_epp() instead of duplicating code.
> 
> Remove an unnecessary check for active mode in online and offline
> functions.
> 
> Eliminate a redundant function amd_pstate_epp_offline().
> 
> Dhananjay Ugwekar (5):
>    cpufreq/amd-pstate: Convert the amd_pstate_get/set_epp() to static
>      calls
>    cpufreq/amd-pstate: Move the invocation of amd_pstate_update_perf()
>    cpufreq/amd-pstate: Refactor amd_pstate_epp_reenable() and
>      amd_pstate_epp_offline()
>    cpufreq/amd-pstate: Remove the cppc_state check in offline/online
>      functions
>    cpufreq/amd-pstate: Merge amd_pstate_epp_cpu_offline() and
>      amd_pstate_epp_offline()
> 
>   drivers/cpufreq/amd-pstate.c | 151 +++++++++++++++++------------------
>   1 file changed, 73 insertions(+), 78 deletions(-)
> 

For the patches not already reviewed:

Reviewed-by: Mario Limonciello <mario.limonciello@....com>

I'll add this to superm1/bleeding-edge.

I have another series that I will build on top of it as well.