[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20241204-marvelous-lubricant-048e71139b32@spud>
Date: Wed, 4 Dec 2024 17:48:20 +0000
From: Conor Dooley <conor@...nel.org>
To: Thippeswamy Havalige <thippeswamy.havalige@....com>
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
manivannan.sadhasivam@...aro.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org,
gustavo.pimentel@...opsys.com, linux-pci@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
jingoohan1@...il.com, michal.simek@....com,
bharat.kumar.gogada@....com
Subject: Re: [PATCH v3 1/3] dt-bindings: PCI: dwc: Add AMD Versal2 mdb slcr
support
On Wed, Dec 04, 2024 at 05:20:24PM +0530, Thippeswamy Havalige wrote:
> Add support for mdb slcr aperture that is only supported for AMD Versal2
> devices.
>
> Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@....com>
> ---
> Changes in v3:
> -------------
> - Introduced below changes in dwc yaml schema.
> ---
> Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> index 548f59d76ef2..02cc04339d75 100644
> --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> @@ -113,6 +113,8 @@ properties:
> enum: [ smu, mpu ]
> - description: Tegra234 aperture
> enum: [ ecam ]
> + - description: AMD MDB PCIe slcr region
> + enum: [ mdb_pcie_slcr ]
Why's this an enum when it has a single value? Shouldn't it be a const?
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists