[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4ab9673a-03a7-4358-b95d-eef514607bc2@broadcom.com>
Date: Wed, 4 Dec 2024 11:08:46 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
Dave Stevenson <dave.stevenson@...pberrypi.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>, Eric Anholt <eric@...olt.net>,
MaĆra Canal <mcanal@...lia.com>,
Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
Doug Berger <opendmb@...il.com>, Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
linux-gpio@...r.kernel.org
Subject: Re: [PATCH 7/7] arm64: dts: broadcom: Fix device tree errors on
BCM2712.
On 12/2/24 07:24, Krzysztof Kozlowski wrote:
> On 02/12/2024 15:32, Dave Stevenson wrote:
>> Resolves the issues on clocks and power nodes
>
> Which issues? Be specific. Such commit is unprecise and not really
> helpful. We see it from the diff that this is "some issue". What we do
> not see is WHY and WHAT the ISSUE is.
A link to the robot email would have probably been helpful in
understanding which dt checker errors are being fixed here. Regardless,
as indicated in patch #4, those commit messages will be discarded since
I intend to fixup the original commits directly into my tree I would not
put too much effort into addressing any comments there, unless there is
some piece of information that should have been provided in the original
commit, in which case I can squash, rather than fixup.
--
Florian
Powered by blists - more mailing lists