linux-kernel - Re: [PATCH 8/9] arm64: dts: renesas: r8a779h0: Add display support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWa0frtVLJcoz7QRe=ZHa24K9MxyV5-_Ce4AUJo+LDEGA@mail.gmail.com>
Date: Wed, 4 Dec 2024 20:20:44 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>, 
	Kieran Bingham <kieran.bingham+renesas@...asonboard.com>, 
	Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Robert Foss <rfoss@...nel.org>, Jonas Karlman <jonas@...boo.se>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Magnus Damm <magnus.damm@...il.com>, Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, LUU HOAI <hoai.luu.ub@...esas.com>, 
	Jagan Teki <jagan@...rulasolutions.com>, Sam Ravnborg <sam@...nborg.org>, 
	Biju Das <biju.das.jz@...renesas.com>, dri-devel@...ts.freedesktop.org, 
	linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, 
	Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>, 
	Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Subject: Re: [PATCH 8/9] arm64: dts: renesas: r8a779h0: Add display support

Hi Tomi,

On Wed, Dec 4, 2024 at 5:04 PM Tomi Valkeinen
<tomi.valkeinen@...asonboard.com> wrote:
> On 03/12/2024 11:37, Laurent Pinchart wrote:
> > On Tue, Dec 03, 2024 at 10:01:42AM +0200, Tomi Valkeinen wrote:
> >> From: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
> >>
> >> Add the device nodes for supporting DU and DSI.
> >>
> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
> >> ---
> >>   arch/arm64/boot/dts/renesas/r8a779h0.dtsi | 77 +++++++++++++++++++++++++++++++
> >>   1 file changed, 77 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/renesas/r8a779h0.dtsi b/arch/arm64/boot/dts/renesas/r8a779h0.dtsi
> >> index 12d8be3fd579..82df6ee98afb 100644
> >> --- a/arch/arm64/boot/dts/renesas/r8a779h0.dtsi
> >> +++ b/arch/arm64/boot/dts/renesas/r8a779h0.dtsi
> >> @@ -1828,6 +1828,54 @@ csi41isp1: endpoint {
> >>                      };
> >>              };
> >>
> >> +            fcpvd0: fcp@...10000 {
> >> +                    compatible = "renesas,fcpv";
> >> +                    reg = <0 0xfea10000 0 0x200>;
> >> +                    clocks = <&cpg CPG_MOD 508>;
> >> +                    power-domains = <&sysc R8A779H0_PD_C4>;
> >> +                    resets = <&cpg 508>;
> >> +            };
> >> +
> >> +            vspd0: vsp@...20000 {
> >> +                    compatible = "renesas,vsp2";
> >> +                    reg = <0 0xfea20000 0 0x8000>;
> >> +                    interrupts = <GIC_SPI 546 IRQ_TYPE_LEVEL_HIGH>;
> >
> > The documentation lists this interrupt as being LevelSensitive and
> > Negative. I wouldn't expect the VSP to work at all with a wrong polarity
> > in DT, so the level may get inverted somewhere.
>
> Indeed... It's the same for V4H. And it also has IRQ_TYPE_LEVEL_HIGH in
> the dts. I tried changing it to LOW on V4H, but:
>
> genirq: Setting trigger mode 8 for irq 91 failed
> vsp1 fea20000.vsp: failed to request IRQ
>
> I didn't dig further yet.

Yeah, I don't think the GIC supports anything but IRQ_TYPE_LEVEL_HIGH.
Which brings us to the two ISP nodes on R-Car V4H and V4M, both using
IRQ_TYPE_LEVEL_LOW.
Niklas: looks like drivers/media/platform/renesas/rcar-isp.c doesn't
actually use the IRQ, so I guess that's how this could slip in?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds