linux-kernel - Re: [PATCH][next] afs: remove redudant use of variable ret in afs_dir_iterate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1399909.1733339000@warthog.procyon.org.uk>
Date: Wed, 04 Dec 2024 19:03:20 +0000
From: David Howells <dhowells@...hat.com>
To: Colin Ian King <colin.i.king@...il.com>
Cc: dhowells@...hat.com, Marc Dionne <marc.dionne@...istor.com>,
    linux-afs@...ts.infradead.org, kernel-janitors@...r.kernel.org,
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] afs: remove redudant use of variable ret in afs_dir_iterate_contents

Colin Ian King <colin.i.king@...il.com> wrote:

> The variable ret is being initialized with 0 and is never re-assigned.
> At the end of the function the check for ret being set to -ESTALE
> is always false, so the check and the call to afs_invalidate_dir is
> redundant. Remove ret and this check and just return 0 at the end
> of the function.

This is the wrong thing to do.  We need to get the error out.  I'm fixing my
patch to do that.

Thanks,
David