linux-kernel - Re: [RFC PATCH v1 05/14] dt-bindings: clock: thead,th1520: Add support for Video Output subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d15dc75cb5d0346bb56c58d4a933cf7e.sboyd@kernel.org>
Date: Wed, 04 Dec 2024 12:22:47 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>, Michal Wilczynski <m.wilczynski@...sung.com>, airlied@...il.com, aou@...s.berkeley.edu, conor+dt@...nel.org, drew@...7.com, frank.binns@...tec.com, guoren@...nel.org, jassisinghbrar@...il.com, jszhang@...nel.org, krzk+dt@...nel.org, m.szyprowski@...sung.com, maarten.lankhorst@...ux.intel.com, matt.coster@...tec.com, mripard@...nel.org, mturquette@...libre.com, palmer@...belt.com, paul.walmsley@...ive.com, robh@...nel.org, simona@...ll.ch, tzimmermann@...e.de, ulf.hansson@...aro.org, wefu@...hat.com
Cc: linux-clk@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org, dri-devel@...ts.freedesktop.org, linux-pm@...r.kernel.org
Subject: Re: [RFC PATCH v1 05/14] dt-bindings: clock: thead,th1520: Add support for Video Output subsystem

Quoting Stephen Boyd (2024-12-04 12:21:11)
> Quoting Michal Wilczynski (2024-12-04 02:11:26)
> > 
> > To address this, I'll specify the 'reg' property in each node to define
> > the address ranges explicitly fragmenting the address space for the VOSYS
> > manually.
> > 
> > vosys_clk: clock-controller@...f528050 {
> >         compatible = "thead,th1520-clk-vo";
> >         reg = <0xff 0xef528050 0x0 0x8>;
> >         #clock-cells = <1>;
> > };
> > 
> > pd: power-domain@...f528000 {
> >         compatible = "thead,th1520-pd";
> >         reg = <0xff 0xef528000 0x0 0x8>;
> >         #power-domain-cells = <1>;
> > };
> 
> You should have one node:
> 
>     clock-controller@...f528000 {
>       compatible = "thead,th1520-vo";
>       reg = <0xff 0xef528050 0x0 0x1a04>;

Apologies for the typo. Here's the correct line:

	reg = <0xff 0xef528000 0x0 0x1a04>;

>       #clock-cells = <1>;
>       #power-domain-cells = <1>;
>     };
>