linux-kernel - Re: [PATCH v2 2/7] clk: qcom: rpmh: Add support for SM8750 rpmh clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cbe51ea-01a0-4adf-af41-314d42ec6d65@quicinc.com>
Date: Wed, 4 Dec 2024 10:12:24 +0530
From: Taniya Das <quic_tdas@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Melody Olvera
	<quic_molvera@...cinc.com>
CC: Bjorn Andersson <andersson@...nel.org>,
        Michael Turquette
	<mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        "Satya Durga
 Srinivasu Prabhala" <quic_satyap@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "Bryan
 O'Donoghue" <bryan.odonoghue@...aro.org>
Subject: Re: [PATCH v2 2/7] clk: qcom: rpmh: Add support for SM8750 rpmh
 clocks



On 11/19/2024 7:28 AM, Dmitry Baryshkov wrote:
> On Mon, Nov 18, 2024 at 10:53:16AM -0800, Melody Olvera wrote:
>> On 11/15/2024 7:31 AM, Dmitry Baryshkov wrote:
>>> On Mon, Nov 11, 2024 at 04:28:02PM -0800, Melody Olvera wrote:
>>>> From: Taniya Das <quic_tdas@...cinc.com>
> 
> [...]
> 
>>>> @@ -894,6 +919,7 @@ static const struct of_device_id clk_rpmh_match_table[] = {
>>>>    	{ .compatible = "qcom,sa8775p-rpmh-clk", .data = &clk_rpmh_sa8775p},
>>>>    	{ .compatible = "qcom,sar2130p-rpmh-clk", .data = &clk_rpmh_sar2130p},
>>>>    	{ .compatible = "qcom,sc7180-rpmh-clk", .data = &clk_rpmh_sc7180},
>>>> +	{ .compatible = "qcom,sc7280-rpmh-clk", .data = &clk_rpmh_sc7280},
>>>>    	{ .compatible = "qcom,sc8180x-rpmh-clk", .data = &clk_rpmh_sc8180x},
>>>>    	{ .compatible = "qcom,sc8280xp-rpmh-clk", .data = &clk_rpmh_sc8280xp},
>>>>    	{ .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845},
>>>> @@ -909,7 +935,7 @@ static const struct of_device_id clk_rpmh_match_table[] = {
>>>>    	{ .compatible = "qcom,sm8450-rpmh-clk", .data = &clk_rpmh_sm8450},
>>>>    	{ .compatible = "qcom,sm8550-rpmh-clk", .data = &clk_rpmh_sm8550},
>>>>    	{ .compatible = "qcom,sm8650-rpmh-clk", .data = &clk_rpmh_sm8650},
>>>> -	{ .compatible = "qcom,sc7280-rpmh-clk", .data = &clk_rpmh_sc7280},
>>> Please don't mix fixes and actual code. I'd suggest splitting sc7280
>>> move to the separate commit.
>>
>> Bryan O'Donoghue requested we sort these as part of this patch. I don't feel
>> strongly either way,
>> but clear guidance here would be appreciated.
> 
> I don't see v1 of this patch on the linux-arm-msm list (hint: use b4
> tool to send patches), so I can not comment on what Bryan ment. But I'd
> definitely say, moving of the sc7280 entry is a _separate_ commit.
> 
>>

I will push the latest patch fixing the issues in this patch.

>> Thanks,
>> Melody
>>
>>>
>>>> +	{ .compatible = "qcom,sm8750-rpmh-clk", .data = &clk_rpmh_sm8750},
>>>>    	{ .compatible = "qcom,x1e80100-rpmh-clk", .data = &clk_rpmh_x1e80100},
>>>>    	{ }
>>>>    };
>>>> -- 
>>>> 2.46.1
>>>>
>>
> 

-- 
Thanks & Regards,
Taniya Das.