linux-kernel - Re: [PATCH] speakup: Fix the wrong format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z1DY7PPuTA0y86ey@begin>
Date: Wed, 4 Dec 2024 23:34:20 +0100
From: Samuel Thibault <samuel.thibault@...-lyon.org>
To: liujing <liujing@...s.chinamobile.com>
Cc: w.d.hubbs@...il.com, chris@...-brannons.com, kirk@...sers.ca,
	masahiroy@...nel.org, nicolas@...sle.eu, speakup@...ux-speakup.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] speakup: Fix the wrong format specifier

liujing, le mer. 04 déc. 2024 23:03:03 +0800, a ecrit:
> Make a minor change to eliminate a static checker warning. The type
> of '(unsigned int)kp[i]' is unsigned int, so the correct format specifier should be
> %u instead of %d.
> 
> Signed-off-by: liujing <liujing@...s.chinamobile.com>

Reviewed-by: Samuel Thibault <samuel.thibault@...-lyon.org>

Thanks!

> diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> index 0882bab10fb8..9bd78e1f023b 100644
> --- a/drivers/accessibility/speakup/genmap.c
> +++ b/drivers/accessibility/speakup/genmap.c
> @@ -153,7 +153,7 @@ main(int argc, char *argv[])
>  			continue;
>  		printf("\n\t%d,", lc);
>  		for (i = 0; i < max_states; i++)
> -			printf(" %d,", (unsigned int)kp[i]);
> +			printf(" %u,", (unsigned int)kp[i]);
>  	}
>  	printf("\n\t0, %d\n", map_ver);
>  
> -- 
> 2.27.0