linux-kernel - Re: [PATCH v3 5/5] sched_ext: Replace bpf_ktime_get_ns() to scx_bpf_clock_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30f6b59b-f288-4923-9d06-25e0138cfe29@igalia.com>
Date: Wed, 4 Dec 2024 14:41:07 +0900
From: Changwoo Min <changwoo@...lia.com>
To: Tejun Heo <tj@...nel.org>, Changwoo Min <multics69@...il.com>
Cc: void@...ifault.com, mingo@...hat.com, peterz@...radead.org,
 kernel-dev@...lia.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/5] sched_ext: Replace bpf_ktime_get_ns() to
 scx_bpf_clock_get_ns()

Hello,

On 24. 12. 4. 08:40, Tejun Heo wrote:
> On Tue, Dec 03, 2024 at 11:28:02PM +0900, Changwoo Min wrote:
>> @@ -245,7 +245,7 @@ void BPF_STRUCT_OPS(central_running, struct task_struct *p)
>>   	s32 cpu = scx_bpf_task_cpu(p);
>>   	u64 *started_at = ARRAY_ELEM_PTR(cpu_started_at, cpu, nr_cpu_ids);
>>   	if (started_at)
>> -		*started_at = bpf_ktime_get_ns() ?: 1;	/* 0 indicates idle */
>> +		*started_at = scx_bpf_clock_get_ns() ?: 1;	/* 0 indicates idle */
> 
> Not from this commit, but how about scx_bpf_now_ns() for the name?
> 
> Thanks.
> 

That sounds good. I will change the function name in the next version.

Regards,
Changwoo Min