linux-kernel - Re: [PATCH 5/5] net: renesas: rswitch: remove speed from gwca structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f574d7d-b087-41b6-a554-b19c24cff1df@intel.com>
Date: Tue, 3 Dec 2024 16:28:55 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Nikita Yushchenko <nikita.yoush@...entembedded.com>, Yoshihiro Shimoda
	<yoshihiro.shimoda.uh@...esas.com>, Andrew Lunn <andrew@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Geert
 Uytterhoeven" <geert+renesas@...der.be>
CC: <netdev@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Michael Dege <michael.dege@...esas.com>,
	Christian Mardmoeller <christian.mardmoeller@...esas.com>, Dennis Ostermann
	<dennis.ostermann@...esas.com>
Subject: Re: [PATCH 5/5] net: renesas: rswitch: remove speed from gwca
 structure



On 12/2/2024 5:49 AM, Nikita Yushchenko wrote:
> This field is set but never used.
> 
> GWCA is rswitch CPU interface module which connects rswitch to the
> host over AXI bus. Speed of the switch ports is not anyhow related to
> GWCA operation.
> 
> Signed-off-by: Nikita Yushchenko <nikita.yoush@...entembedded.com>
> ---

I tried grepping the code and didn't find any other users either.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

This one also could be a cleanup that goes to next since there doesn't
appear to be any user visible bug.

>  drivers/net/ethernet/renesas/rswitch.c | 3 ---
>  drivers/net/ethernet/renesas/rswitch.h | 1 -
>  2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> index 5980084d9211..bef344e0b1fd 100644
> --- a/drivers/net/ethernet/renesas/rswitch.c
> +++ b/drivers/net/ethernet/renesas/rswitch.c
> @@ -1902,9 +1902,6 @@ static int rswitch_device_alloc(struct rswitch_private *priv, unsigned int index
>  	if (err < 0)
>  		goto out_get_params;
>  
> -	if (rdev->priv->gwca.speed < rdev->etha->speed)
> -		rdev->priv->gwca.speed = rdev->etha->speed;
> -
>  	err = rswitch_rxdmac_alloc(ndev);
>  	if (err < 0)
>  		goto out_rxdmac;
> diff --git a/drivers/net/ethernet/renesas/rswitch.h b/drivers/net/ethernet/renesas/rswitch.h
> index 72e3ff596d31..303883369b94 100644
> --- a/drivers/net/ethernet/renesas/rswitch.h
> +++ b/drivers/net/ethernet/renesas/rswitch.h
> @@ -993,7 +993,6 @@ struct rswitch_gwca {
>  	DECLARE_BITMAP(used, RSWITCH_MAX_NUM_QUEUES);
>  	u32 tx_irq_bits[RSWITCH_NUM_IRQ_REGS];
>  	u32 rx_irq_bits[RSWITCH_NUM_IRQ_REGS];
> -	int speed;
>  };
>  
>  #define NUM_QUEUES_PER_NDEV	2