linux-kernel - Re: [PATCH] ptp: Switch back to struct platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241203171910.27c0a170@kernel.org>
Date: Tue, 3 Dec 2024 17:19:10 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>, richardcochran@...il.com,
 yangbo.lu@....com, dwmw2@...radead.org, Linus Torvalds
 <torvalds@...ux-foundation.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, Linux-Next <linux-next@...r.kernel.org>
Subject: Re: [PATCH] ptp: Switch back to struct platform_driver::remove()

On Tue, 3 Dec 2024 12:49:54 +0100 Uwe Kleine-König wrote:
> > Resolution: just take the version from upstream.  
> 
> But IMHO my variant is better than Linus's. After Linus' change the =
> for .probe and .remove are aligned in the conflicting files. However the
> other members initialized there are only using a single space before the
> =. My change used the single space variant consistently for the whole
> initializer.
> 
> So I suggest to either drop my change, or in the conflict resolution
> take my variant and not Linus's.

I'll revert, it's less work.