linux-kernel - RE: [PATCH 2/3] udmabuf: also check for F_SEAL_FUTURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA0PR11MB71852E284842DD85061F9CDBF8372@IA0PR11MB7185.namprd11.prod.outlook.com>
Date: Wed, 4 Dec 2024 09:09:17 +0000
From: "Kasireddy, Vivek" <vivek.kasireddy@...el.com>
To: Jann Horn <jannh@...gle.com>, Gerd Hoffmann <kraxel@...hat.com>, "Sumit
 Semwal" <sumit.semwal@...aro.org>, Christian König
	<christian.koenig@....com>, Simona Vetter <simona.vetter@...ll.ch>, "John
 Stultz" <john.stultz@...aro.org>, Andrew Morton <akpm@...ux-foundation.org>,
	"Joel Fernandes (Google)" <joel@...lfernandes.org>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH 2/3] udmabuf: also check for F_SEAL_FUTURE_WRITE

> Subject: [PATCH 2/3] udmabuf: also check for F_SEAL_FUTURE_WRITE
> 
> When F_SEAL_FUTURE_WRITE was introduced, it was overlooked that
> udmabuf
> must reject memfds with this flag, just like ones with F_SEAL_WRITE.
> Fix it by adding F_SEAL_FUTURE_WRITE to SEALS_DENIED.
> 
> Fixes: ab3948f58ff8 ("mm/memfd: add an F_SEAL_FUTURE_WRITE seal to
> memfd")
> Cc: stable@...r.kernel.org
> Signed-off-by: Jann Horn <jannh@...gle.com>
> ---
>  drivers/dma-buf/udmabuf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
> index
> 662b9a26e06668bf59ab36d07c0648c7b02ee5ae..8ce77f5837d71a73be677ca
> d014e05f29706057d 100644
> --- a/drivers/dma-buf/udmabuf.c
> +++ b/drivers/dma-buf/udmabuf.c
> @@ -297,7 +297,7 @@ static const struct dma_buf_ops udmabuf_ops = {
>  };
> 
>  #define SEALS_WANTED (F_SEAL_SHRINK)
> -#define SEALS_DENIED (F_SEAL_WRITE)
> +#define SEALS_DENIED (F_SEAL_WRITE|F_SEAL_FUTURE_WRITE)
Acked-by: Vivek Kasireddy <vivek.kasireddy@...el.com>

> 
>  static int check_memfd_seals(struct file *memfd)
>  {
> 
> --
> 2.47.0.338.g60cca15819-goog