linux-kernel - Re: [PATCH v2 1/2] dt-bindings: iio: adc: Add binding for Nuvoton NCT720x ADCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+4VgcJs7kwHyjj0VtVkicK7j+XNh6aAcexg+cVp5sgPNnRzrQ@mail.gmail.com>
Date: Wed, 4 Dec 2024 16:47:40 +0800
From: Yu-Hsian Yang <j2anfernee@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com, 
	venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com, 
	jic23@...nel.org, lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, nuno.sa@...log.com, dlechner@...libre.com, 
	javier.carrasco.cruz@...il.com, andriy.shevchenko@...ux.intel.com, 
	marcelo.schmitt@...log.com, olivier.moysan@...s.st.com, 
	mitrutzceclan@...il.com, tgamblin@...libre.com, matteomartelli3@...il.com, 
	alisadariana@...il.com, gstols@...libre.com, thomas.bonnefille@...tlin.com, 
	ramona.nechita@...log.com, mike.looijmans@...ic.nl, 
	chanh@...amperecomputing.com, KWLIU@...oton.com, yhyang2@...oton.com, 
	openbmc@...ts.ozlabs.org, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: Add binding for Nuvoton
 NCT720x ADCs

Dear Krzysztof Kozlowski,

Krzysztof Kozlowski <krzk@...nel.org> 於 2024年12月4日 週三 下午3:13寫道：
>
> On 04/12/2024 04:10, Yu-Hsian Yang wrote:
> >>> +  reg:
> >>> +    maxItems: 1
> >>
> >>
> >> No other properties? No resources?
> >>
> >
> > The difference is to remove read-vin-data-size property and default
> > use read word vin data.
>
>
> No supplies? No interrupts?
>

We would add interrupts and reset-gpios but not include in required block.
Add these two properties in todo list.
+  interrupts:
+    maxItems: 1

+  reset-gpios:
+    description:
+      Reset pin for the device.
+    maxItems: 1

Besides, I found a mistake that the Node name should follow.
> +        nct7202@1d {
So, correct it as
 +        adc@1d {

>
> Best regards,
> Krzysztof