linux-kernel - Re: [PATCH v2 4/7] dt-bindings: clock: qcom: Add SM8750 GCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cfb08783-a561-4636-853e-0903713008f8@quicinc.com>
Date: Wed, 4 Dec 2024 14:54:53 +0530
From: Taniya Das <quic_tdas@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Melody Olvera
	<quic_molvera@...cinc.com>
CC: Bjorn Andersson <andersson@...nel.org>,
        Michael Turquette
	<mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        "Satya Durga
 Srinivasu Prabhala" <quic_satyap@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/7] dt-bindings: clock: qcom: Add SM8750 GCC



On 12/4/2024 12:47 PM, Taniya Das wrote:
> 
> 
> On 11/20/2024 1:47 PM, Krzysztof Kozlowski wrote:
>> On Mon, Nov 11, 2024 at 04:28:04PM -0800, Melody Olvera wrote:
>>> From: Taniya Das <quic_tdas@...cinc.com>
>>>
>>> Add bindings documentation for the SM8750 General Clock Controller.
>>
>> Subject prefix - use proper file prefix:
>> dt-bindings: clock: qcom,sm8650-gcc:
>>
>>>
>>> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
>>> Signed-off-by: Melody Olvera <quic_molvera@...cinc.com>
>>> ---
>>>   .../bindings/clock/qcom,sm8650-gcc.yaml       |   8 +-
>>>   include/dt-bindings/clock/qcom,sm8750-gcc.h   | 226 ++++++++++++++++++
>>>   2 files changed, 232 insertions(+), 2 deletions(-)
>>>   create mode 100644 include/dt-bindings/clock/qcom,sm8750-gcc.h
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml 
>>> b/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml
>>> index 976f29cce809..e50b5f1cad75 100644
>>> --- a/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml
>>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml
>>> @@ -13,11 +13,15 @@ description: |
>>>     Qualcomm global clock control module provides the clocks, resets 
>>> and power
>>>     domains on SM8650
>>> -  See also:: include/dt-bindings/clock/qcom,sm8650-gcc.h
>>> +  See also: include/dt-bindings/clock/qcom,sm8650-gcc.h
>>> +            include/dt-bindings/reset/qcom,sm8750-gcc.h
>>>   properties:
>>>     compatible:
>>> -    const: qcom,sm8650-gcc
>>> +    items:
>>
>> No need for items, simpler is just enum.
>>
> 
> will fix in the next patch.
> 

As there are binding differences between SM8650 and SM8750 will bring 
back the new file as in v1 
https://patchwork.kernel.org/project/linux-clk/patch/20241021230359.2632414-5-quic_molvera@quicinc.com/ 
  and fix the unused bindings.

>>> +      - enum:
>>> +          - qcom,sm8650-gcc
>>> +          - qcom,sm8750-gcc
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>
>> Best regards,
>> Krzysztof
>>
> 

-- 
Thanks & Regards,
Taniya Das.