linux-kernel - Re: [PATCH net-next v5 3/5] net: phy: Kconfig: Add ptp library support and 1588 optional flag in Microchip phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67b0c8ac-5079-478c-9495-d255f063a828@lunn.ch>
Date: Wed, 4 Dec 2024 02:39:54 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Divya Koppera <divya.koppera@...rochip.com>
Cc: arun.ramadoss@...rochip.com, UNGLinuxDriver@...rochip.com,
	hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	richardcochran@...il.com, vadim.fedorenko@...ux.dev
Subject: Re: [PATCH net-next v5 3/5] net: phy: Kconfig: Add ptp library
 support and 1588 optional flag in Microchip phys

On Tue, Dec 03, 2024 at 02:22:46PM +0530, Divya Koppera wrote:
> Add ptp library support in Kconfig
> As some of Microchip T1 phys support ptp, add dependency
> of 1588 optional flag in Kconfig
> 
> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> Signed-off-by: Divya Koppera <divya.koppera@...rochip.com>
> ---
> v4 -> v5
> Addressed below review comments.
> - Indentation fix
> - Changed dependency check to if check for PTP_1588_CLOCK_OPTIONAL
> 
> v1 -> v2 -> v3 -> v4
> - No changes
> ---
>  drivers/net/phy/Kconfig | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index 15828f4710a9..e97d389bb250 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -287,8 +287,15 @@ config MICROCHIP_PHY
>  
>  config MICROCHIP_T1_PHY
>  	tristate "Microchip T1 PHYs"
> +	select MICROCHIP_PHYPTP if NETWORK_PHY_TIMESTAMPING && \
> +				  PTP_1588_CLOCK_OPTIONAL
>  	help
> -	  Supports the LAN87XX PHYs.
> +	  Supports the LAN8XXX PHYs.
> +
> +config MICROCHIP_PHYPTP
> +	tristate "Microchip PHY PTP"
> +	help
> +	  Currently supports LAN887X T1 PHY

How many different PTP implementations does Microchip have?

I see mscc_ptp.c, lan743x_ptp.c, lan966x_ptp.c and sparx5_ptp.c. Plus
this one.

Does Microchip keep reinventing the wheel? Or can this library be used
in place of any of these? And how many more ptp implementations will
microchip have in the future? Maybe MICROCHIP_PHYPTP is too generic,
maybe you should leave space for the next PTP implementation?

	Andrew