linux-kernel - Re: [PATCH linux next] delayacct: add delay max to record delay peak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241204094321160yp9RJKElKXTlg-q1OzYU-@zte.com.cn>
Date: Wed, 4 Dec 2024 09:43:21 +0800 (CST)
From: <yang.yang29@....com.cn>
To: <jiang.kun2@....com.cn>
Cc: <bsingharora@...il.com>, <david@...hat.com>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <linux-doc@...r.kernel.org>, <wang.yong12@....com.cn>,
        <wang.yaxin@....com.cn>, <fan.yu9@....com.cn>, <he.peilin@....com.cn>,
        <tu.qiang35@....com.cn>, <qiu.yutan@....com.cn>,
        <zhang.yunkai@....com.cn>, <ye.xingchen@....com.cn>,
        <xu.xin16@....com.cn>, <akpm@...ux-foundation.org>,
        <Liu.Jianjun3@....com.cn>, <tan.hu@....com.cn>,
        <jiang.xuexin@....com.cn>
Subject: Re: [PATCH linux next] delayacct: add delay max to record delay peak

On Tue, 3 Dec 2024 16:48:48 +0800 (CST) <jiang.kun2@....com.cn> wrote:

> From: Wang Yaxin <wang.yaxin@....com.cn>
> the 'delay max' can display delay peak since the system's startup

What about also add 'delay min' ? This could help us get to know how
large the difference is between min and max, provide clues for optimizing
potential. This is also some benchmark tools do, like stream which print:
precision of your system timer.
-------------------------------------------------------------
Function    Best Rate MB/s  Avg time     Min time     Max time
Copy:          234195.8     0.073357     0.073357     0.073357
Scale:         163856.6     0.104847     0.104847     0.104847
Add:           177791.5     0.144944     0.144944     0.144944

And please also update Documentation/accounting/delay-accounting.rst.
Other parts LGTM, thanks!