linux-kernel - Re: [PATCH 1/5] mm/vma: move brk() internals to mm/vma.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ec57d7f-c6b9-469e-973b-95389b131376@lucifer.local>
Date: Wed, 4 Dec 2024 12:10:32 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: kernel test robot <lkp@...el.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, oe-kbuild-all@...ts.linux.dev,
        Linux Memory Management List <linux-mm@...ck.org>,
        "Liam R . Howlett" <Liam.Howlett@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Jann Horn <jannh@...gle.com>,
        Eric Biederman <ebiederm@...ssion.com>, Kees Cook <kees@...nel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] mm/vma: move brk() internals to mm/vma.c

On Wed, Dec 04, 2024 at 07:55:16PM +0800, kernel test robot wrote:
> Hi Lorenzo,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on akpm-mm/mm-everything]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Lorenzo-Stoakes/mm-vma-move-brk-internals-to-mm-vma-c/20241204-115150
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
> patch link:    https://lore.kernel.org/r/3d24b9e67bb0261539ca921d1188a10a1b4d4357.1733248985.git.lorenzo.stoakes%40oracle.com
> patch subject: [PATCH 1/5] mm/vma: move brk() internals to mm/vma.c
> config: mips-allnoconfig (https://download.01.org/0day-ci/archive/20241204/202412041907.3DXYQrz6-lkp@intel.com/config)
> compiler: mips-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241204/202412041907.3DXYQrz6-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202412041907.3DXYQrz6-lkp@intel.com/

Thanks for the report!

Seems to be missing a header to include/uapi/linux/personality.h which declares
READ_IMPLES_EXEC, however the standard means of including this appears to be
including linux/personality.h which also imports this header.

I have sent a fixpatch separately.

>
> All errors (new ones prefixed by >>):
>
>    In file included from arch/mips/include/asm/cacheflush.h:13,
>                     from include/linux/cacheflush.h:5,
>                     from include/linux/highmem.h:8,
>                     from include/linux/bvec.h:10,
>                     from include/linux/blk_types.h:10,
>                     from include/linux/writeback.h:13,
>                     from include/linux/backing-dev.h:16,
>                     from mm/vma_internal.h:12,
>                     from mm/vma.c:7:
>    mm/vma.c: In function 'do_brk_flags':
> >> include/linux/mm.h:450:44: error: 'READ_IMPLIES_EXEC' undeclared (first use in this function)
>      450 | #define TASK_EXEC ((current->personality & READ_IMPLIES_EXEC) ? VM_EXEC : 0)
>          |                                            ^~~~~~~~~~~~~~~~~
>    include/linux/mm.h:453:55: note: in expansion of macro 'TASK_EXEC'
>      453 | #define VM_DATA_FLAGS_TSK_EXEC  (VM_READ | VM_WRITE | TASK_EXEC | \
>          |                                                       ^~~~~~~~~
>    arch/mips/include/asm/page.h:215:33: note: in expansion of macro 'VM_DATA_FLAGS_TSK_EXEC'
>      215 | #define VM_DATA_DEFAULT_FLAGS   VM_DATA_FLAGS_TSK_EXEC
>          |                                 ^~~~~~~~~~~~~~~~~~~~~~
>    mm/vma.c:2503:18: note: in expansion of macro 'VM_DATA_DEFAULT_FLAGS'
>     2503 |         flags |= VM_DATA_DEFAULT_FLAGS | VM_ACCOUNT | mm->def_flags;
>          |                  ^~~~~~~~~~~~~~~~~~~~~
>    include/linux/mm.h:450:44: note: each undeclared identifier is reported only once for each function it appears in
>      450 | #define TASK_EXEC ((current->personality & READ_IMPLIES_EXEC) ? VM_EXEC : 0)
>          |                                            ^~~~~~~~~~~~~~~~~
>    include/linux/mm.h:453:55: note: in expansion of macro 'TASK_EXEC'
>      453 | #define VM_DATA_FLAGS_TSK_EXEC  (VM_READ | VM_WRITE | TASK_EXEC | \
>          |                                                       ^~~~~~~~~
>    arch/mips/include/asm/page.h:215:33: note: in expansion of macro 'VM_DATA_FLAGS_TSK_EXEC'
>      215 | #define VM_DATA_DEFAULT_FLAGS   VM_DATA_FLAGS_TSK_EXEC
>          |                                 ^~~~~~~~~~~~~~~~~~~~~~
>    mm/vma.c:2503:18: note: in expansion of macro 'VM_DATA_DEFAULT_FLAGS'
>     2503 |         flags |= VM_DATA_DEFAULT_FLAGS | VM_ACCOUNT | mm->def_flags;
>          |                  ^~~~~~~~~~~~~~~~~~~~~
>
>
> vim +/READ_IMPLIES_EXEC +450 include/linux/mm.h
>
> a8bef8ff6ea15fa Mel Gorman        2010-05-24  449
> c62da0c35d58518 Anshuman Khandual 2020-04-10 @450  #define TASK_EXEC ((current->personality & READ_IMPLIES_EXEC) ? VM_EXEC : 0)
> c62da0c35d58518 Anshuman Khandual 2020-04-10  451
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki