linux-kernel - Re: Lockdep splat on UMS disconnect (6.13-rc1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z1BHt0lqYDIm3nXH@fedora>
Date: Wed, 4 Dec 2024 20:14:47 +0800
From: Ming Lei <ming.lei@...hat.com>
To: Johan Hovold <johan@...nel.org>
Cc: Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
	Alan Stern <stern@...land.harvard.edu>, linux-block@...r.kernel.org,
	linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
	linux-kernel@...r.kernel.org, regressions@...ts.linux.dev
Subject: Re: Lockdep splat on UMS disconnect (6.13-rc1)

On Wed, Dec 04, 2024 at 12:26:53PM +0100, Johan Hovold wrote:
> Hi,
> 
> I'm seeing a new lockdep splat with 6.13-rc1 on resume after having
> disconnected a USB mass storage device while suspended. This does not
> seem to show up with 6.12.
> 
> On one attempt to reproduce this with a ThinkPad T14s, the NVMe was
> hosed after resume as well so I fear that this is not just about missing
> annotation.
> 
> I don't have time to look into this myself right now so I'm reporting in
> the hope that someone familiar with these paths would be able to
> pinpoint any potential regression without too much effort.
> 

The dependency between lock(&q->q_usage_counter(queue)#3) and lock(&q->limits_lock)
is real trouble.

The real deadlock was reported before:

https://lore.kernel.org/linux-scsi/ZxG38G9BuFdBpBHZ@fedora/

And the warning can be triggered by the following command too:

	echo 'none' > /sys/block/sda/queue/write_cache


Thanks,
Ming