linux-kernel - Re: [PATCH v3 1/2] hwmon: (asus-ec-sensors) AMD 600 motherboard add support for fan cpu opt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB95QAQLh3mnfWxB9rnsAzNQ+e43=2xZNP3h4HcWY7jYQ8Yi_g@mail.gmail.com>
Date: Wed, 4 Dec 2024 12:44:52 +0100
From: Eugene Shalygin <eugene.shalygin@...il.com>
To: Li XingYang <yanhuoguifan@...il.com>
Cc: jdelvare@...e.com, linux@...ck-us.net, corbet@....net, 
	linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] hwmon: (asus-ec-sensors) AMD 600 motherboard add
 support for fan cpu opt

LGTM.

Best Regards,
Eugene

On Sun, 1 Dec 2024 at 04:48, Li XingYang <yanhuoguifan@...il.com> wrote:
>
> Refer to the LibreHardwareMonitor project, LibreHardwareMonitorLib/
> Hardware/Motherboard/Lpc/EC/EmbeddedController.cs file,
> fan cpu opt is support by amd600 EC.
> the registers are described:
> BoardFamily.Amd600, new Dictionary<ECSensor, EmbeddedControllerSource>
> {
> { ECSensor.FanCPUOpt,  new EmbeddedControllerSource
> ("CPU Optional Fan", SensorType.Fan, 0x00b0, 2) },
> }
>
> now add the FanCPUOpt support for amd600
>
> Signed-off-by: Li XingYang <yanhuoguifan@...il.com>
> ---
>  drivers/hwmon/asus-ec-sensors.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 9555366aeaf0..381bf117104f 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -250,6 +250,8 @@ static const struct ec_sensor_info sensors_family_amd_600[] = {
>                 EC_SENSOR("Water_In", hwmon_temp, 1, 0x01, 0x00),
>         [ec_sensor_temp_water_out] =
>                 EC_SENSOR("Water_Out", hwmon_temp, 1, 0x01, 0x01),
> +       [ec_sensor_fan_cpu_opt] =
> +               EC_SENSOR("CPU_Opt", hwmon_fan, 2, 0x00, 0xb0),
>  };
>
>  static const struct ec_sensor_info sensors_family_intel_300[] = {
> --
> 2.47.1
>