linux-kernel - Re: [PATCH v1] audit: fix suffixed '/' filename matching in __audit_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAABTaaCXu6aeTLwVngOpnCVQJ1z3_TYcdjiA=nkvGyvTN1O8TQ@mail.gmail.com>
Date: Wed, 4 Dec 2024 10:36:06 -0300
From: Ricardo Robaina <rrobaina@...hat.com>
To: Paul Moore <paul@...l-moore.com>
Cc: Al Viro <viro@...iv.linux.org.uk>, audit@...r.kernel.org, 
	linux-kernel@...r.kernel.org, eparis@...hat.com, rgb@...hat.com
Subject: Re: [PATCH v1] audit: fix suffixed '/' filename matching in __audit_inode_child()

Hello everyone, thank you all who reviewed this patch!

On Wed, Nov 27, 2024 at 2:43 AM Paul Moore <paul@...l-moore.com> wrote:
>
> > Anyway, regarding audit_compare_dname_path(), handling just the last '/' is
> > not enough - there might be any number of trailing slashes, not just one.
>
> Good reminder, thanks.  I see that Ricardo has sent an updated patch,
> I haven't looked at it yet (waiting for the merge window to close),
> but hopefully he has taken that into account (hint: now would be a
> good time to verify that Ricardo <g>).
>

Yes, I did take this into account. As well as the other cleanup suggestions.

- Ricardo