linux-kernel - Re: [PATCH v3 04/13] rust: hrtimer: implement `TimerPointer` for `Arc`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wmgfefak.fsf@kernel.org>
Date: Wed, 04 Dec 2024 14:41:39 +0100
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@...il.com>
Cc: "Lyude Paul" <lyude@...hat.com>,  "Miguel Ojeda" <ojeda@...nel.org>,
  "Anna-Maria Behnsen" <anna-maria@...utronix.de>,  "Frederic Weisbecker"
 <frederic@...nel.org>,  "Thomas Gleixner" <tglx@...utronix.de>,  "Alex
 Gaynor" <alex.gaynor@...il.com>,  "Boqun Feng" <boqun.feng@...il.com>,
  "Gary Guo" <gary@...yguo.net>,  Björn Roy Baron
 <bjorn3_gh@...tonmail.com>,  "Benno Lossin" <benno.lossin@...ton.me>,
  "Alice Ryhl" <aliceryhl@...gle.com>,  "Trevor Gross" <tmgross@...ch.edu>,
  <rust-for-linux@...r.kernel.org>,  <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 04/13] rust: hrtimer: implement `TimerPointer` for `Arc`

"Miguel Ojeda" <miguel.ojeda.sandonis@...il.com> writes:

> On Wed, Nov 20, 2024 at 4:52 PM Andreas Hindborg <a.hindborg@...nel.org> wrote:
>>
>> No particular reason. It is often easier to rebase things around when
>> they are on their own line.
>>
>> Are there any code guidelines to follow on this?
>
> Not yet -- we have a mixture of styles, though we typically don't go
> to the item-level like in this patch, and instead have done it closer
> to the "Crate" or "Module" styles.

What is the rationale behind this bias? Perhaps we should do a pros/cons
list before settling on a style.

It is arguably easier to merge and rebase when using the `Item` policy.


Best regards,
Andreas Hindborg