linux-kernel - Re: [PATCH] RDMA/uverbs: Prevent integer overflow issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173332200266.3892997.8099565115676880659.b4-ty@kernel.org>
Date: Wed, 04 Dec 2024 09:20:02 -0500
From: Leon Romanovsky <leon@...nel.org>
To: Roland Dreier <roland@...nel.org>, 
 Dan Carpenter <dan.carpenter@...aro.org>
Cc: Jason Gunthorpe <jgg@...pe.ca>, Christian Brauner <brauner@...nel.org>, 
 Erick Archer <erick.archer@....com>, 
 Akiva Goldberger <agoldberger@...dia.com>, linux-rdma@...r.kernel.org, 
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] RDMA/uverbs: Prevent integer overflow issue


On Sat, 30 Nov 2024 13:06:41 +0300, Dan Carpenter wrote:
> In the expression "cmd.wqe_size * cmd.wr_count", both variables are u32
> values that come from the user so the multiplication can lead to integer
> wrapping.  Then we pass the result to uverbs_request_next_ptr() which also
> could potentially wrap.  The "cmd.sge_count * sizeof(struct ib_uverbs_sge)"
> multiplication can also overflow on 32bit systems although it's fine on
> 64bit systems.
> 
> [...]

Applied, thanks!

[1/1] RDMA/uverbs: Prevent integer overflow issue
      https://git.kernel.org/rdma/rdma/c/d0257e089d1bbd

Best regards,
-- 
Leon Romanovsky <leon@...nel.org>