linux-kernel - Re: [PATCH v2] wifi: mac80211: re-order unassigning channel in activate links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a60eb1a7-9739-4dbc-a683-417ac6d47adc@quicinc.com>
Date: Thu, 5 Dec 2024 20:43:12 +0530
From: Aditya Kumar Singh <quic_adisi@...cinc.com>
To: Johannes Berg <johannes@...solutions.net>
CC: <linux-wireless@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] wifi: mac80211: re-order unassigning channel in
 activate links

On 12/5/24 18:30, Johannes Berg wrote:
> On Thu, 2024-12-05 at 12:43 +0100, Johannes Berg wrote:
>>>
>>> Therefore, re-order the logic so that stations are handled first and then
>>> channel is unassigned.
>>>
>>
>> This causes memory leaks in my tests with iwlwifi.
>>
> 
> And also firmware crashes because the station is removed while it's
> still being used.
> 

So is this exposing some underlying issue with iwlwifi? Or this change 
will break drivers which does not group multiple hardware into single 
wiphy?

Also, how about non-ML scenario in iwlwifi? There, first station is 
removed and then the interface goes down right?

-- 
Aditya