linux-kernel - Re: [PATCH v1] dt-bindings: dma: st-stm32-dmamux: Add description for dma-cell values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28d1bb46-ab18-42da-9ca2-ff498c888d66@kernel.org>
Date: Thu, 5 Dec 2024 17:09:35 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ken Sloat <ksloat@...nersoftsolutions.com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 dmaengine@...r.kernel.org, alexandre.torgue@...s.st.com,
 mcoquelin.stm32@...il.com, conor+dt@...nel.org, krzk+dt@...nel.org,
 robh@...nel.org, vkoul@...nel.org, amelie.delaunay@...s.st.com
Subject: Re: [PATCH v1] dt-bindings: dma: st-stm32-dmamux: Add description for
 dma-cell values

On 05/12/2024 17:07, Ken Sloat wrote:
>>> + 1. The mux input number/line for the request
>>> + 2. Bitfield representing DMA channel configuration that is passed
>>> + to the real DMA controller
>>> + 3. Bitfield representing device dependent DMA features passed to
>>> + the real DMA controller
>>> +
>>> + For bitfield definitions of cells 2 and 3, see the associated
>>> + bindings doc for the actual DMA controller the mux is connected
>>
>> This does not sound right. This is the binding for DMA controller, so
>> you are saying "please look at itself". I suggest to drop this as well.
>>
> 
> While logically it is the DMA controller, this doc is specifically for
> the mux - the DMA controller has its own driver and binding docs in
> Documentation/devicetree/bindings/dma/stm32/st,stm32-dma.yaml
> 
> I can reference st,stm32-dma.yaml directly, but I was unsure if this
> mux IP was used with another DMA controller from ST on a different
> SoC.
> 
> What do you suggest here?

Thanks for explanation, I think it is fine.

Best regards,
Krzysztof