linux-kernel - Re: [PATCH V4 RESEND net-next 2/7] net: hibmcge: Add irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241205162537.GB2581@kernel.org>
Date: Thu, 5 Dec 2024 16:25:37 +0000
From: Simon Horman <horms@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, andrew+netdev@...n.ch, shenjian15@...wei.com,
	wangpeiyang1@...wei.com, liuyonglong@...wei.com,
	chenhao418@...wei.com, sudongming1@...wei.com,
	xujunsheng@...wei.com, shiyongbang@...wei.com, libaihan@...wei.com,
	jonathan.cameron@...wei.com, shameerali.kolothum.thodi@...wei.com,
	salil.mehta@...wei.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, hkelam@...vell.com
Subject: Re: [PATCH V4 RESEND net-next 2/7] net: hibmcge: Add irq_info file
 to debugfs

On Tue, Dec 03, 2024 at 11:01:26PM +0800, Jijie Shao wrote:
> the driver requested three interrupts: "tx", "rx", "err".
> The err interrupt is a summary interrupt. We distinguish
> different errors based on the status register and mask.
> 
> With "cat /proc/interrupts | grep hibmcge",
> we can't distinguish the detailed cause of the error,
> so we added this file to debugfs.
> 
> the following effects are achieved:
> [root@...alhost sjj]# cat /sys/kernel/debug/hibmcge/0000\:83\:00.1/irq_info
> RX                  : enabled: true , logged: false, count: 0
> TX                  : enabled: true , logged: false, count: 0
> MAC_MII_FIFO_ERR    : enabled: false, logged: true , count: 0
> MAC_PCS_RX_FIFO_ERR : enabled: false, logged: true , count: 0
> MAC_PCS_TX_FIFO_ERR : enabled: false, logged: true , count: 0
> MAC_APP_RX_FIFO_ERR : enabled: false, logged: true , count: 0
> MAC_APP_TX_FIFO_ERR : enabled: false, logged: true , count: 0
> SRAM_PARITY_ERR     : enabled: true , logged: true , count: 0
> TX_AHB_ERR          : enabled: true , logged: true , count: 0
> RX_BUF_AVL          : enabled: true , logged: false, count: 0
> REL_BUF_ERR         : enabled: true , logged: true , count: 0
> TXCFG_AVL           : enabled: true , logged: false, count: 0
> TX_DROP             : enabled: true , logged: false, count: 0
> RX_DROP             : enabled: true , logged: false, count: 0
> RX_AHB_ERR          : enabled: true , logged: true , count: 0
> MAC_FIFO_ERR        : enabled: true , logged: false, count: 0
> RBREQ_ERR           : enabled: true , logged: false, count: 0
> WE_ERR              : enabled: true , logged: false, count: 0
> 
> The irq framework of hibmcge driver also includes tx/rx interrupts.
> Therefore, TX and RX are not moved separately form this file.
> 
> Signed-off-by: Jijie Shao <shaojijie@...wei.com>

Reviewed-by: Simon Horman <horms@...nel.org>