linux-kernel - Re: [PATCH net v4] ethtool: Fix wrong mod state in case of verbose and no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173336883303.1427062.8314508421207042104.git-patchwork-notify@kernel.org>
Date: Thu, 05 Dec 2024 03:20:33 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: mkubecek@...e.cz, davem@...emloft.net, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, o.rempel@...gutronix.de,
 thomas.petazzoni@...tlin.com, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, horms@...nel.org, richardcochran@...il.com
Subject: Re: [PATCH net v4] ethtool: Fix wrong mod state in case of verbose and
 no_mask bitset

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon,  2 Dec 2024 16:33:57 +0100 you wrote:
> A bitset without mask in a _SET request means we want exactly the bits in
> the bitset to be set. This works correctly for compact format but when
> verbose format is parsed, ethnl_update_bitset32_verbose() only sets the
> bits present in the request bitset but does not clear the rest. The commit
> 6699170376ab ("ethtool: fix application of verbose no_mask bitset") fixes
> this issue by clearing the whole target bitmap before we start iterating.
> The solution proposed brought an issue with the behavior of the mod
> variable. As the bitset is always cleared the old value will always
> differ to the new value.
> 
> [...]

Here is the summary with links:
  - [net,v4] ethtool: Fix wrong mod state in case of verbose and no_mask bitset
    https://git.kernel.org/netdev/net/c/910c4788d615

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html