linux-kernel - Re: [RFC PATCH v2 2/6] x86/virt/tdx: Add SEAMCALL wrappers for TDX TD creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <090da4a7e0184ec86a127e1d463aa7dd5076b8eb.camel@intel.com>
Date: Thu, 5 Dec 2024 17:25:55 +0000
From: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To: "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "pbonzini@...hat.com"
	<pbonzini@...hat.com>, "Hansen, Dave" <dave.hansen@...el.com>,
	"seanjc@...gle.com" <seanjc@...gle.com>
CC: "yuan.yao@...el.com" <yuan.yao@...el.com>, "Huang, Kai"
	<kai.huang@...el.com>, "x86@...nel.org" <x86@...nel.org>,
	"binbin.wu@...ux.intel.com" <binbin.wu@...ux.intel.com>, "Li, Xiaoyao"
	<xiaoyao.li@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Zhao, Yan Y" <yan.y.zhao@...el.com>,
	"tony.lindgren@...ux.intel.com" <tony.lindgren@...ux.intel.com>,
	"isaku.yamahata@...il.com" <isaku.yamahata@...il.com>, "Hunter, Adrian"
	<adrian.hunter@...el.com>, "Yamahata, Isaku" <isaku.yamahata@...el.com>
Subject: Re: [RFC PATCH v2 2/6] x86/virt/tdx: Add SEAMCALL wrappers for TDX TD
 creation

On Wed, 2024-12-04 at 11:54 -0800, Dave Hansen wrote:
> On 12/2/24 17:03, Rick Edgecombe wrote:
> > +u64 tdh_mng_addcx(struct tdx_td *td, struct page *tdcs_page)
> > +{
> > +	struct tdx_module_args args = {
> > +		.rcx = page_to_pfn(tdcs_page) << PAGE_SHIFT,
> 
> This is a nit, but there is a page_to_phys().

I almost used that, but the macro casts to dma_addr_t which didn't quite fit
these callers. Seems ok though.