linux-kernel - Re: [PATCH v2] drm/panel: visionox-rm69299: Remove redundant assignments of panel fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4bf2d14-395a-4147-97f1-e5fb41669822@quicinc.com>
Date: Thu, 5 Dec 2024 09:54:02 -0800
From: Jessica Zhang <quic_jesszhan@...cinc.com>
To: Chen-Yu Tsai <wenst@...omium.org>,
        Neil Armstrong
	<neil.armstrong@...aro.org>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
CC: <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drm/panel: visionox-rm69299: Remove redundant
 assignments of panel fields



On 12/4/2024 1:39 AM, Chen-Yu Tsai wrote:
> drm_panel_init() was made to initialize the fields in |struct drm_panel|.
> There is no need to separately initialize them again.
> 
> Drop the separate assignments that are redundant. Also fix up any uses
> of `ctx->panel.dev` to use `dev` directly.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@...omium.org>

Reviewed-by: Jessica Zhang <quic_jesszhan@...cinc.com>

> ---
> Changes since v1:
> - Also fix uses of `ctx->panel.dev`
> 
>   drivers/gpu/drm/panel/panel-visionox-rm69299.c | 9 ++-------
>   1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> index 272490b9565b..be3a9797fbce 100644
> --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> @@ -193,7 +193,6 @@ static int visionox_rm69299_probe(struct mipi_dsi_device *dsi)
>   
>   	mipi_dsi_set_drvdata(dsi, ctx);
>   
> -	ctx->panel.dev = dev;
>   	ctx->dsi = dsi;
>   
>   	ctx->supplies[0].supply = "vdda";
> @@ -201,13 +200,11 @@ static int visionox_rm69299_probe(struct mipi_dsi_device *dsi)
>   	ctx->supplies[1].supply = "vdd3p3";
>   	ctx->supplies[1].init_load_uA = 13200;
>   
> -	ret = devm_regulator_bulk_get(ctx->panel.dev, ARRAY_SIZE(ctx->supplies),
> -				      ctx->supplies);
> +	ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), ctx->supplies);
>   	if (ret < 0)
>   		return ret;
>   
> -	ctx->reset_gpio = devm_gpiod_get(ctx->panel.dev,
> -					 "reset", GPIOD_OUT_LOW);
> +	ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
>   	if (IS_ERR(ctx->reset_gpio)) {
>   		dev_err(dev, "cannot get reset gpio %ld\n", PTR_ERR(ctx->reset_gpio));
>   		return PTR_ERR(ctx->reset_gpio);
> @@ -215,8 +212,6 @@ static int visionox_rm69299_probe(struct mipi_dsi_device *dsi)
>   
>   	drm_panel_init(&ctx->panel, dev, &visionox_rm69299_drm_funcs,
>   		       DRM_MODE_CONNECTOR_DSI);
> -	ctx->panel.dev = dev;
> -	ctx->panel.funcs = &visionox_rm69299_drm_funcs;
>   	drm_panel_add(&ctx->panel);
>   
>   	dsi->lanes = 4;
> -- 
> 2.47.0.338.g60cca15819-goog
>