linux-kernel - Re: [PATCH v1] perf test expr: Fix system_tsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1H10jkXnGqC1vWg@google.com>
Date: Thu, 5 Dec 2024 10:49:54 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	James Clark <james.clark@...aro.org>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, akanksha@...ux.ibm.com,
	maddy@...ux.ibm.com, atrajeev@...ux.vnet.ibm.com,
	kjain@...ux.ibm.com, disgoel@...ux.vnet.ibm.com,
	hbathini@...ux.ibm.com
Subject: Re: [PATCH v1] perf test expr: Fix system_tsc_freq for only x86

On Wed, Dec 04, 2024 at 11:09:50PM -0800, Ian Rogers wrote:
> On Wed, Dec 4, 2024 at 10:33 PM Ian Rogers <irogers@...gle.com> wrote:
> >
> > On Wed, Dec 4, 2024 at 9:47 PM Namhyung Kim <namhyung@...nel.org> wrote:
> > >
> > > Hi Ian,
> > >
> > > On Wed, Dec 04, 2024 at 06:23:05PM -0800, Ian Rogers wrote:
> > > > The refactoring of tool PMU events to have a PMU then adding the expr
> > > > literals to the tool PMU made it so that the literal system_tsc_freq
> > > > was only supported on x86. Update the test expectations to match -
> > > > namely the parsing is x86 specific and only yields a non-zero value on
> > > > Intel.
> > > >
> > > > Fixes: 609aa2667f67 ("perf tool_pmu: Switch to standard pmu functions and json descriptions")
> > > > Reported-by: Athira Rajeev <atrajeev@...ux.vnet.ibm.com>
> > > > Closes: https://lore.kernel.org/linux-perf-users/20241022140156.98854-1-atrajeev@linux.vnet.ibm.com/
> > > > Co-developed-by: Athira Rajeev <atrajeev@...ux.vnet.ibm.com>
> > > > Signed-off-by: Ian Rogers <irogers@...gle.com>
> > >
> > > It failed on my VM.
> > >
> > >   root@...64-vm:~/build# ./perf test -v 7
> > >   --- start ---
> > >   test child forked, pid 2096
> > >   Using CPUID 0x00000000000f0510
> > >   division by zero
> > >   syntax error
> > >   Unrecognized literal '#system_tsc_freq'FAILED tests/expr.c:253 #system_tsc_freq == 0
> > >   ---- end(-1) ----
> > >     7: Simple expression parser                                        : FAILED!
> >
> > I'll need to check this. The test is looking for parsing failures, so
> > it's confusing to me expr__parse is returning 0. I was testing on x86
> > but disabling the literal in the tool PMU.
> 
> Hmm.. perhaps you had a similar issue to me and that b4 silently
> failed as git user.email/user.name weren't configured? When I test on

No, I confirmed it's appplied.  Maybe my VM setting has some problem.
After reboot + rebuild it works now, sorry for the noise.

Thanks,
Namhyung


> a raspberry pi 5:
> ```
> $ uname -a
> Linux raspberrypi 6.6.51+rpt-rpi-2712 #1 SMP PREEMPT Debian
> 1:6.6.51-1+rpt3 (2024-10-08) aarch64 GNU/Linux
> $ git log -1 --oneline
> 94733a0e50fd (HEAD -> ptn-expr-test) perf test expr: Fix
> system_tsc_freq for only x86
> $ /tmp/perf/perf test expr -v
> Couldn't bump rlimit(MEMLOCK), failures may take place when creating
> BPF maps, etc
>   7: Simple expression parser                                        : Ok
> ```
> 
> Thanks,
> Ian