linux-kernel - Re: [PATCH v4 3/3] hwmon: (pmbus/tps25990): add initial support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72486280-1852-41a2-ae17-2288d7fedd54@ijzerbout.nl>
Date: Thu, 5 Dec 2024 20:50:14 +0100
From: Kees Bakker <kees@...erbout.nl>
To: Jerome Brunet <jbrunet@...libre.com>, Jean Delvare <jdelvare@...e.com>,
 Guenter Roeck <linux@...ck-us.net>, Jonathan Corbet <corbet@....net>,
 Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
Cc: linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
 Vaishnav Achath <vaishnav.a@...com>
Subject: Re: [PATCH v4 3/3] hwmon: (pmbus/tps25990): add initial support

Op 02-12-2024 om 11:28 schreef Jerome Brunet:
> Add initial support for the Texas Instruments TPS25990 eFuse.
> This adds the basic PMBUS telemetry support for the device.
>
> Tested-by: Vaishnav Achath <vaishnav.a@...com>
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
> ---
>   Documentation/hwmon/index.rst    |   1 +
>   Documentation/hwmon/tps25990.rst | 148 +++++++++++++
>   MAINTAINERS                      |   2 +
>   drivers/hwmon/pmbus/Kconfig      |  17 ++
>   drivers/hwmon/pmbus/Makefile     |   1 +
>   drivers/hwmon/pmbus/tps25990.c   | 437 +++++++++++++++++++++++++++++++++++++++
>   6 files changed, 606 insertions(+)
>
> [...]
> diff --git a/drivers/hwmon/pmbus/tps25990.c b/drivers/hwmon/pmbus/tps25990.c
> new file mode 100644
> index 0000000000000000000000000000000000000000..0a267014c88997fca5e83b2ec974a0d521808512
> [...]
> +	case PMBUS_VIRT_READ_IIN_MAX:
> +		return TPS25990_READ_IIN_PEAK;
> +		ret = pmbus_read_word_data(client, page, phase,
> +					   TPS25990_READ_IIN_PEAK);
> +		break;
> [...]
Is the return intended? Or some left-over debug code?
-- 
Kees