linux-kernel - Re: [PATCH 1/2] doc: module: Fix documented type of namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATMufXP0EA6QUE9hBkZMa6vJO6ZiaYuak2AhOrd2nSVKQ@mail.gmail.com>
Date: Thu, 5 Dec 2024 12:58:20 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Jani Nikula <jani.nikula@...ux.intel.com>
Cc: Uwe Kleine-König <u.kleine-koenig@...libre.com>, 
	Matthias Maennich <maennich@...gle.com>, Jonathan Corbet <corbet@....net>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>, 
	Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/2] doc: module: Fix documented type of namespace

On Wed, Dec 4, 2024 at 7:38 PM Jani Nikula <jani.nikula@...ux.intel.com> wrote:
>
> On Wed, 04 Dec 2024, Uwe Kleine-König <u.kleine-koenig@...libre.com> wrote:
> > Since commit cdd30ebb1b9f ("module: Convert symbol namespace to string
> > literal") the namespace has to be a string. Fix accordingly.
>
> Interesting. Using preprocessor symbols inherently restricted the
> namespace syntax to that of C identifiers.
>
> Is it now okay to use any syntax for the namespaces from now on? Should
> the document have some recommendations for naming namespaces?

I guess the answer is yes except for whitespaces.

The namespaces are recorded in the Module.symvers file,
which is also parsed by external programs like kmod.
Using whitespaces within namespaces may confuse the field separators.
Otherwise, the namespace is a simple string matching as far as I can tell.






-- 
Best Regards
Masahiro Yamada