linux-kernel - Re: [RFC][PATCH] sched: deadline: Remove unnecessary goto label in pick_earliest_pushable_dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANDhNCqpC7JxNVjUzsERaMh2VXxkhoGQwPqrnGAH89hgRZA8XQ@mail.gmail.com>
Date: Thu, 5 Dec 2024 13:47:00 -0800
From: John Stultz <jstultz@...gle.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...hat.com>, 
	Peter Zijlstra <peterz@...radead.org>, Juri Lelli <juri.lelli@...hat.com>, 
	Vincent Guittot <vincent.guittot@...aro.org>, Dietmar Eggemann <dietmar.eggemann@....com>, 
	Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, 
	Valentin Schneider <vschneid@...hat.com>, Wanpeng Li <wanpeng.li@...ux.intel.com>, 
	Todd Kjos <tkjos@...gle.com>, kernel-team@...roid.com
Subject: Re: [RFC][PATCH] sched: deadline: Remove unnecessary goto label in pick_earliest_pushable_dl_task

On Thu, Dec 5, 2024 at 1:23 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> Le 05/12/2024 à 22:16, John Stultz a écrit :
> > Commit 8b5e770ed7c0 ("sched/deadline: Optimize pull_dl_task()")
> > added an odd goto label that seems to be unnecssary, given its
>
> s/unnecssary/unnecessary/
>
> > called unconditionally from the bottom of a while loop and the
> > label is at the top.
>
> Except that it is not a while loop, but only an if.

Ah! Apologies. I need to get my eyes checked. :P  Thank you for
catching me there.

> Maybe, changing this if into a while would save a few lines of code and
> be more readable as-well.

Yeah, Todd pointed out the unconventional usage, but my brain mis-read
the code as being a while(). I'll resend with that change.

thanks
-john