linux-kernel - Re: [PATCH v2] of: WARN on deprecated #address-cells/#size-cells handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54b34ac1296dd6711bda5239069d5e3b436bbc8f.camel@amazon.com>
Date: Thu, 5 Dec 2024 22:01:29 +0000
From: "Herrenschmidt, Benjamin" <benh@...zon.com>
To: "robh@...nel.org" <robh@...nel.org>, "segher@...nel.crashing.org"
	<segher@...nel.crashing.org>
CC: "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"mpe@...erman.id.au" <mpe@...erman.id.au>, "saravanak@...gle.com"
	<saravanak@...gle.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "conor@...nel.org" <conor@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] of: WARN on deprecated #address-cells/#size-cells
 handling

On Mon, 2024-12-02 at 16:55 -0600, Rob Herring wrote:
>         /* Look for this #address-cells. We have to implement the old linux
>          * trick of looking for the parent here as some device-trees rely on it
>          */
> 
> Maybe that's from some system long dropped and we don't need it
> anymore. I have no idea. That's what I'm trying to find out with this
> patch.
> 
> We also don't really have a way to distinguish OF from FDT (where we'd
> need to). It is somewhat just by arch, but PPC always passes an FDT to
> the kernel for both FDT and OF systems.

I probably wrote that :-)

The little I can remember, I think is there are many cases of old DTs
(esp. old Apple ones) missing the "empty" ranges property in some nodes
to indicate that the parent and child address spaces are identical.

I honestly don't remember the specifics, but this is something I did
hit a few times in the past.

Cheers,
Ben.