linux-kernel - Re: [PATCH 1/1] tty: serial: handle HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ed8f7230-6eab-4f8e-b607-877e6c8e5a7d@app.fastmail.com>
Date: Thu, 05 Dec 2024 08:08:08 +0100
From: "Arnd Bergmann" <arnd@...nel.org>
To: "Guenter Roeck" <linux@...ck-us.net>
Cc: "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
 "Niklas Schnelle" <schnelle@...ux.ibm.com>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Jiri Slaby" <jirislaby@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 linux-serial@...r.kernel.org, "Heiko Carstens" <hca@...ux.ibm.com>,
 linux-kernel@...r.kernel.org, "Yang Yingliang" <yangyingliang@...wei.com>
Subject: Re: [PATCH 1/1] tty: serial: handle HAS_IOPORT dependencies

On Wed, Dec 4, 2024, at 23:44, Guenter Roeck wrote:
> On 12/4/24 14:17, Arnd Bergmann wrote:
>> On Wed, Dec 4, 2024, at 22:09, Guenter Roeck wrote:
>> 
>> I had considered this at first but didn't really want to do
>> it like this because we should not be registering empty ports
>> on platforms that don't use the setserial style override for
>> the port configuration.
>> 
>> It does of course address the warning, just not the
>> underlying bug.
>> 
>
> I had a look myself, and concluded that a clean fix will likely require
> substantial changes to avoid regressions. Your patch series pretty much
> confirms that. This is why I came up with the hack below. Yes, it doesn't
> get rid of the underlying problem, but IMO it is good enough for 6.13,
> or at least not worse than 6.12, while at the same time avoiding the
> warning backtrace. It seems to me that a clean fix would be 6.14 material,
> and I really don't want those backtraces to clog up test logs until then.

Fair enough, let's use your patch then for 6,13,

Acked-by: Arnd Bergmann <arnd@...db.de>