linux-kernel - Re: [PATCH net-next v3 09/10] net: freescale: ucc_geth: Introduce a helper to check Reduced modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241205083230.2344d850@fedora.home>
Date: Thu, 5 Dec 2024 08:32:30 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: davem@...emloft.net, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Russell King
 <linux@...linux.org.uk>, Christophe Leroy <christophe.leroy@...roup.eu>,
 Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com, Simon Horman
 <horms@...nel.org>, Herve Codina <herve.codina@...tlin.com>, Uwe
 Kleine-König <u.kleine-koenig@...libre.com>,
 linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH net-next v3 09/10] net: freescale: ucc_geth: Introduce a
 helper to check Reduced modes

On Wed, 4 Dec 2024 16:41:33 +0100
Andrew Lunn <andrew@...n.ch> wrote:

> On Wed, Dec 04, 2024 at 09:22:32AM +0100, Maxime Chevallier wrote:
> > Hello Andrew,
> > 
> > On Wed, 4 Dec 2024 03:15:52 +0100
> > Andrew Lunn <andrew@...n.ch> wrote:
> >   
> > > > +static bool phy_interface_mode_is_reduced(phy_interface_t interface)
> > > > +{
> > > > +	return phy_interface_mode_is_rgmii(interface) ||
> > > > +	       interface == PHY_INTERFACE_MODE_RMII ||
> > > > +	       interface == PHY_INTERFACE_MODE_RTBI;
> > > > +}    
> > > 
> > > I wounder if this is useful anywhere else? Did you take a look around
> > > other MAC drivers? Maybe this should be in phy.h?  
> > 
> > Yes I did consider it but it looks like ucc_geth is the only driver
> > that has a configuration that applies to all R(MII/GMII/TBI) interfaces  
> 
> O.K. What is important is you considered it. Thanks. Too many
> developers are focus on just their driver and don't think about other
> drivers and code reuse.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Thanks Andrew. I should have indicated that in the commit log or in the
cover in the first place though, I'll make sure to do it next time.

Maxime