linux-kernel - Re: [PATCH v10 3/8] dt-bindings: mfd: add maxim,max77705

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55f32164-f504-4409-8ce2-6462b833da89@kernel.org>
Date: Thu, 5 Dec 2024 08:54:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dzmitry Sankouski <dsankouski@...il.com>
Cc: Sebastian Reichel <sre@...nel.org>, Chanwoo Choi <cw00.choi@...sung.com>,
 Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>, Pavel Machek <pavel@....cz>,
 Hans de Goede <hdegoede@...hat.com>,
 Marek Szyprowski <m.szyprowski@...sung.com>,
 Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>,
 Purism Kernel Team <kernel@...i.sm>, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-input@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH v10 3/8] dt-bindings: mfd: add maxim,max77705

On 05/12/2024 08:48, Krzysztof Kozlowski wrote:
>> +        patternProperties:
>> +          "^led@[0-3]$":
>> +            type: object
>> +            $ref: /schemas/leds/common.yaml#
>> +            unevaluatedProperties: false
>> +
>> +            properties:
>> +              reg:
>> +                maxItems: 1
>> +
>> +            required:
>> +              - reg
>> +
>> +    required:
>> +      - compatible
>> +
>> +patternProperties:
>> +  "^fuel-gauge@[0-9a-f]+$":
> 
> 
> How unit address appeared here? It was absolutely never reviewed. This
> is significant change, so drop the review tag.
> 
> It's also a no, drop unit address.

To explain more:
In the few Maxim PMIC/MUIC charger designs known to me, the fuel gauge
is a separate device. In all implementations it is even on separate bus,
although does not have to. You claim that this is not a separate device
and you even claim that this *MUST* be on the same bus.

Both claims sound just wrong, IMO. This needs explanation. It seems you
develop bindings just to match your drivers and that is not the correct
process. Bindings must match the hardware, not your driver architecture.


Best regards,
Krzysztof