[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <vxe5ml2zwg2kg5ui2mz4ws2mc3fj6whvnvvft3x6ezr7fhkdrd@ipghbtncp3en>
Date: Thu, 5 Dec 2024 09:59:29 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vabhav Sharma <vabhav.sharma@....com>
Cc: Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Dong Aisheng <aisheng.dong@....com>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, frank.li@....com,
pankaj.gupta@....com, daniel.baluta@....com, silvano.dininno@....com, V.Sethi@....com,
meenakshi.aggarwal@....com
Subject: Re: [PATCH v4 1/4] dt-bindings: firmware: imx: add nvmem phandle
On Thu, Dec 05, 2024 at 05:56:32AM +0100, Vabhav Sharma wrote:
> nvmem phandle is required by secvio driver to
> read fuse.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> Signed-off-by: Vabhav Sharma <vabhav.sharma@....com>
> ---
> Documentation/devicetree/bindings/firmware/fsl,scu.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> index 557e524786c2..c88d9c2dac24 100644
> --- a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> +++ b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> @@ -112,6 +112,9 @@ properties:
> - const: rx2
> - const: rx3
> - const: gip3
Unresolved comment. I would normally add conditional ack, but this is
second time you ignore comments, so I don't trust you on that. Sad that
such trivial things will require respin.
> + nvmem:
> + description:
> + phandle of NVMEM controller provided by the SCU
Best regards,
Krzysztof
Powered by blists - more mailing lists