linux-kernel - Re: [PATCH 6.12 000/826] 6.12.2-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024120504-verbose-hurried-eb52@gregkh>
Date: Thu, 5 Dec 2024 10:23:51 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Naresh Kamboju <naresh.kamboju@...aro.org>,
	Sasha Levin <sashal@...nel.org>, stable@...r.kernel.org,
	patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	linux@...ck-us.net, shuah@...nel.org, patches@...nelci.org,
	lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
	f.fainelli@...il.com, sudipm.mukherjee@...il.com,
	srw@...dewatkins.net, rwarsow@....de, conor@...nel.org,
	hargar@...rosoft.com, broonie@...nel.org,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	Anders Roxell <anders.roxell@...aro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	Alexander Stein <alexander.stein@...tq-group.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Michal Suchanek <msuchanek@...e.de>,
	Nicolai Stange <nstange@...e.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH 6.12 000/826] 6.12.2-rc1 review

On Wed, Dec 04, 2024 at 09:48:53AM -0700, Nathan Chancellor wrote:
> On Wed, Dec 04, 2024 at 06:30:47PM +0530, Naresh Kamboju wrote:
> > On Tue, 3 Dec 2024 at 21:06, Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org> wrote:
> > > The whole patch series can be found in one patch at:
> > >         https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.2-rc1.gz
> > > or in the git tree and branch at:
> > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.12.y
> > > and the diffstat can be found below
> ...
> > 1) The allmodconfig builds failed on arm64, arm, riscv and x86_64
> >      due to following build warnings / errors.
> > 
> > Build errors for allmodconfig:
> > --------------
> > drivers/gpu/drm/imx/ipuv3/parallel-display.c:75:3: error: variable
> > 'num_modes' is uninitialized when used here [-Werror,-Wuninitialized]
> >    75 |                 num_modes++;
> >       |                 ^~~~~~~~~
> > drivers/gpu/drm/imx/ipuv3/parallel-display.c:55:15: note: initialize
> > the variable 'num_modes' to silence this warning
> >    55 |         int num_modes;
> >       |                      ^
> >       |                       = 0
> > 1 error generated.
> > make[8]: *** [scripts/Makefile.build:229:
> > drivers/gpu/drm/imx/ipuv3/parallel-display.o] Error 1
> 
> Introduced by backporting commit 5f6e56d3319d ("drm/imx:
> parallel-display: switch to drm_panel_bridge") without
> commit f94b9707a1c9 ("drm/imx: parallel-display: switch to
> imx_legacy_bridge / drm_bridge_connector"). The latter change also had a
> follow up fix in commit ef214002e6b3 ("drm/imx: parallel-display: add
> legacy bridge Kconfig dependency").
> 
> > drivers/gpu/drm/imx/ipuv3/imx-ldb.c:143:3: error: variable 'num_modes'
> > is uninitialized when used here [-Werror,-Wuninitialized]
> >   143 |                 num_modes++;
> >       |                 ^~~~~~~~~
> > drivers/gpu/drm/imx/ipuv3/imx-ldb.c:133:15: note: initialize the
> > variable 'num_modes' to silence this warning
> >   133 |         int num_modes;
> >       |                      ^
> >       |                       = 0
> > 1 error generated.
> 
> Introduced by backporting commit 5c5843b20bbb ("drm/imx: ldb: switch to
> drm_panel_bridge") without commit 4c3d525f6573 ("drm/imx: ldb: switch to
> imx_legacy_bridge / drm_bridge_connector").
> 
> These are both upstream patch series bisectability issues, not anything
> that stable specifically did, as the num_nodes initialization was
> removed by the first change but the entire function containing num_nodes
> was removed by the second change so when the series was taken atomically
> upstream, nobody notices. However, I do wonder why these patches are
> being picked up, as they don't really read like fixes to me and the
> cover letter of the original series does not really make it seem like it
> either.

Thanks, I'll just rip them both out now.

greg k-h