linux-kernel - Re: [PATCH net-next v12 12/22] ovpn: implement multi-peer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <364f199c-8d8d-4228-bdd7-13ab81d10e39@openvpn.net>
Date: Thu, 5 Dec 2024 11:33:25 +0100
From: Antonio Quartulli <antonio@...nvpn.net>
To: netdev@...r.kernel.org
Cc: Simon Horman <horms@...nel.org>, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Donald Hunter <donald.hunter@...il.com>, Shuah Khan <shuah@...nel.org>,
 sd@...asysnail.net, ryazanov.s.a@...il.com, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next v12 12/22] ovpn: implement multi-peer support

On 02/12/2024 16:07, Antonio Quartulli wrote:
[...]
> +
> +/**
> + * ovpn_peer_unhash - remove peer reference from all hashtables
> + * @peer: the peer to remove
> + * @reason: the delete reason to attach to the peer
> + */
> +static void ovpn_peer_unhash(struct ovpn_peer *peer,
> +			     enum ovpn_del_peer_reason reason)
> +{
> +	lockdep_assert_held(&peer->ovpn->lock);
> +
> +	hlist_del_init_rcu(&peer->hash_entry_id);
> +
> +	hlist_nulls_del_init_rcu(&peer->hash_entry_addr4);
> +	hlist_nulls_del_init_rcu(&peer->hash_entry_addr6);
> +	hlist_nulls_del_init_rcu(&peer->hash_entry_transp_addr);
> +
> +	ovpn_peer_put(peer);

This put() should be dropped as we now call it in ovpn_peer_remove().
Will be fixed in v13.


Regards,

-- 
Antonio Quartulli
OpenVPN Inc.