linux-kernel - Re: [PATCH v15 08/23] x86/virt/tdx: Use all system memory when initializing TDX module as TDX memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f869946fc0ab5b03d53598b252b79be50a6d0ed.camel@intel.com>
Date: Thu, 5 Dec 2024 12:25:10 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "nik.borisov@...e.com" <nik.borisov@...e.com>, "rppt@...nel.org"
	<rppt@...nel.org>
CC: "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"sathyanarayanan.kuppuswamy@...ux.intel.com"
	<sathyanarayanan.kuppuswamy@...ux.intel.com>, "Hansen, Dave"
	<dave.hansen@...el.com>, "david@...hat.com" <david@...hat.com>,
	"bagasdotme@...il.com" <bagasdotme@...il.com>, "Luck, Tony"
	<tony.luck@...el.com>, "ak@...ux.intel.com" <ak@...ux.intel.com>,
	"kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
	"seanjc@...gle.com" <seanjc@...gle.com>, "mingo@...hat.com"
	<mingo@...hat.com>, "pbonzini@...hat.com" <pbonzini@...hat.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>, "Yamahata, Isaku"
	<isaku.yamahata@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "hpa@...or.com" <hpa@...or.com>,
	"peterz@...radead.org" <peterz@...radead.org>, "sagis@...gle.com"
	<sagis@...gle.com>, "imammedo@...hat.com" <imammedo@...hat.com>,
	"bp@...en8.de" <bp@...en8.de>, "Gao, Chao" <chao.gao@...el.com>,
	"rafael@...nel.org" <rafael@...nel.org>, "Brown, Len" <len.brown@...el.com>,
	"ying.huang@...el.com" <ying.huang@...el.com>, "Williams, Dan J"
	<dan.j.williams@...el.com>, "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH v15 08/23] x86/virt/tdx: Use all system memory when
 initializing TDX module as TDX memory

On Thu, 2024-12-05 at 11:06 +0200, Nikolay Borisov wrote:
> > > +/*
> > > + * Ensure that all memblock memory regions are convertible to TDX
> > > + * memory.  Once this has been established, stash the memblock
> > > + * ranges off in a secondary structure because memblock is modified
> > > + * in memory hotplug while TDX memory regions are fixed.
> > > + */
> > > +static int build_tdx_memlist(struct list_head *tmb_list)
> > > +{
> > > +	unsigned long start_pfn, end_pfn;
> > > +	int i, ret;
> > > +
> > > +	for_each_mem_pfn_range(i, MAX_NUMNODES, &start_pfn, &end_pfn, NULL) {
> > 
> > Unles ARCH_KEEP_MEMBLOCK is defined this won't work after free_initmem()
> 
> TDX_HOST actually selects ARCH_KEEP_MEMBLOCK:
> 

Yes.  Thanks Nikolay for reply.  Somehow I missed this one yesterday.