linux-kernel - Re: [PATCH v1] hugetlb: support FOLL_FORCE|FOLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1EIa51dKCrsHdTC@bender.morinfr.org>
Date: Thu, 5 Dec 2024 02:56:59 +0100
From: Guillaume Morin <guillaume@...infr.org>
To: David Hildenbrand <david@...hat.com>
Cc: linux-kernel@...r.kernel.org, oe-kbuild-all@...ts.linux.dev,
	linux-mm@...ck.org, Muchun Song <muchun.song@...ux.dev>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Xu <peterx@...hat.com>,
	Eric Hagberg <ehagberg@...estreet.com>
Subject: Re: [PATCH v1] hugetlb: support FOLL_FORCE|FOLL_WRITE

On 05 Dec  2:42, Guillaume Morin wrote:
>
> On 05 Dec  8:39, kernel test robot wrote:
> > All errors (new ones prefixed by >>):
> > 
> >    mm/gup.c: In function 'can_follow_write_pud':
> > >> mm/gup.c:665:48: error: implicit declaration of function 'pud_soft_dirty'; did you mean 'pmd_soft_dirty'? [-Werror=implicit-function-declaration]
> >      665 |         return !vma_soft_dirty_enabled(vma) || pud_soft_dirty(pud);
> >          |                                                ^~~~~~~~~~~~~~
> >          |                                                pmd_soft_dirty
> >    cc1: some warnings being treated as errors
> 
> David, how do you recommend I deal with this?
> 
> There is no prototype for pud_soft_dirty() in include/linux/pgtable.h
> if CONFIG_HAVE_ARCH_SOFT_DIRTY is not set. Should I just add one?

I am going to respin v3 with that. Let me know if you think it makes
sense or you think it should be fixed some other way

-- 
Guillaume Morin <guillaume@...infr.org>