linux-kernel - Re: [PATCH 1/2] ASoC: codecs: wcd9335: Add define for number of DAIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABTCjFA9DyRzca93qoS5_+sfc2RLfNVNqN14WVfKODjHykwGJQ@mail.gmail.com>
Date: Thu, 5 Dec 2024 16:29:45 +0300
From: Dzmitry Sankouski <dsankouski@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Liam Girdwood <lgirdwood@...il.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, linux-sound@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ASoC: codecs: wcd9335: Add define for number of DAIs

чт, 5 дек. 2024 г. в 15:33, Mark Brown <broonie@...nel.org>:
>
> On Thu, Dec 05, 2024 at 09:40:20AM +0100, Krzysztof Kozlowski wrote:
> > Number of DAIs in the codec is not really a binding, because it could
> > grow, e.g. when we implement missing features.  Add the define to the
> > driver, which will replace the one in the binding header.
>
> This breaks an allmodconfig build:
>
> /build/stage/linux/sound/soc/codecs/wcd9335.c:162: error: "NUM_CODEC_DAIS" redef
> ined [-Werror]
>   162 | #define NUM_CODEC_DAIS          (AIF4_PB + 1)
>       |
> In file included from /build/stage/linux/sound/soc/codecs/wcd9335.c:28:
> /build/stage/linux/include/dt-bindings/sound/qcom,wcd9335.h:13: note: this is th
> e location of the previous definition
>    13 | #define NUM_CODEC_DAIS          7
>       |

This is the 1st patch in series, and NUM_CODEC_DAIS redefine from bindings
is deleted in the 2nd one.