linux-kernel - Re: [PATCH v3 5/8] arm64: dts: renesas: rzg3s-smarc: Fix the debug serial alias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUaMZB0Dmc70DXTPnNu=Vp0p6K3w0A9y53B2OmrR6MeFg@mail.gmail.com>
Date: Fri, 6 Dec 2024 15:57:50 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Claudiu <claudiu.beznea@...on.dev>
Cc: geert+renesas@...der.be, magnus.damm@...il.com, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, mturquette@...libre.com, 
	sboyd@...nel.org, gregkh@...uxfoundation.org, jirislaby@...nel.org, 
	p.zabel@...gutronix.de, lethal@...ux-sh.org, g.liakhovetski@....de, 
	linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, 
	linux-serial@...r.kernel.org, 
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH v3 5/8] arm64: dts: renesas: rzg3s-smarc: Fix the debug
 serial alias

Hi Claudiu,

On Fri, Nov 15, 2024 at 2:50 PM Claudiu <claudiu.beznea@...on.dev> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
>
> The debug serial of the RZ/G3S is SCIF0 which is routed on the Renesas
> RZ SMARC Carrier II board on the SER3_UART. Use serial3 alias for it for
> better hardware description. Along with it, the chosen properties were
> moved to the device tree corresponding to the RZ SMARC Carrier II board.
>
> Fixes: adb4f0c5699c ("arm64: dts: renesas: Add initial support for RZ/G3S SMARC SoM")
> Fixes: d1ae4200bb26 ("arm64: dts: renesas: Add initial device tree for RZ SMARC Carrier-II Board")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi
> @@ -43,11 +43,6 @@ aliases {
>  #endif
>         };
>
> -       chosen {
> -               bootargs = "ignore_loglevel";

I'd say please keep bootargs here, but as you don't support using the
SoM without the carrier board, I guess it's fine to keep it together
with stdout-path.

> -               stdout-path = "serial0:115200n8";
> -       };

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
i.e. will queue in renesas-devel for v6.14.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds