linux-kernel - Re: [PATCH v5 2/4] proc_pid_fdinfo.5: Make pid clearer in the name and 1st paragraph

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241206151937.ldkoo63cvmzvazqz@devuan>
Date: Fri, 6 Dec 2024 16:19:37 +0100
From: Alejandro Colomar <alx@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: "G . Branden Robinson" <g.branden.robinson@...il.com>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Jonathan Corbet <corbet@....net>, dri-devel@...ts.freedesktop.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-man@...r.kernel.org
Subject: Re: [PATCH v5 2/4] proc_pid_fdinfo.5: Make pid clearer in the name
 and 1st paragraph

Hi Ian,

On Thu, Dec 05, 2024 at 11:38:26PM -0800, Ian Rogers wrote:
> Previously the pid was highlighted through being a tagged paragraph
> but not mentioned in the description. Add italics to the path
> emphasizing pid and then change the first sentence to include pid in
> the definition.
> 
> Suggested-by: G. Branden Robinson <g.branden.robinson@...il.com>

I'm going to reject this patch at the moment.  But I'd like to revisit
this patch in the future, so please resend (rebased) in half a year or
so (ideally after the release of groff-1.24.0).

Cheers,
Alex

> ---
> v5. Switch .IR pid to .I pid
> ---
>  man/man5/proc_pid_fdinfo.5 | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/man/man5/proc_pid_fdinfo.5 b/man/man5/proc_pid_fdinfo.5
> index 1c6c38423..2797ae216 100644
> --- a/man/man5/proc_pid_fdinfo.5
> +++ b/man/man5/proc_pid_fdinfo.5
> @@ -6,10 +6,11 @@
>  .\"
>  .TH proc_pid_fdinfo 5 (date) "Linux man-pages (unreleased)"
>  .SH NAME
> -/proc/pid/fdinfo/ \- information about file descriptors
> +.IR /proc/ pid /fdinfo " \- information about file descriptors"
>  .SH DESCRIPTION
> -This is a subdirectory containing one entry for each file which the
> -process has open, named by its file descriptor.
> +This subdirectory contains one entry for each file that process
> +.I pid
> +has open, named by its file descriptor.
>  The files in this directory are readable only by the owner of the process.
>  The contents of each file can be read to obtain information
>  about the corresponding file descriptor.
> -- 
> 2.47.0.338.g60cca15819-goog
> 

-- 
<https://www.alejandro-colomar.es/>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)